pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedIncorrect grammar
6+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2018-02-22 810e7e264a Remove extra word from comment.
2018-02-06 2320945731 Fix incorrect grammar.
* Incorrect grammar
@ 2018-02-06 10:22 Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
0 siblings, 1 reply; 6+ messages in thread
From: Etsuro Fujita @ 2018-02-06 10:22 UTC (permalink / raw)
To: pgsql-hackers
Hi,
While reviewing the
lazy-initialization-of-partition-info-for-tuple-routing patch, I ran
into a grammar mistake in a comment in ExecSetupChildParentMapForLeaf.
Attached is a patch for fixing that.
Best regards,
Etsuro Fujita
Attachments:
fix-incorrect-grammar.patch (text/x-diff, 555B) download
diff --git a/src/backend/executor/execPartition.c b/src/backend/executor/execPartition.c
index 106a96d..ba6b52c 100644
--- a/src/backend/executor/execPartition.c
+++ b/src/backend/executor/execPartition.c
@@ -360,7 +360,7 @@ ExecSetupChildParentMapForLeaf(PartitionTupleRouting *proute)
Assert(proute != NULL);
/*
- * These array elements gets filled up with maps on an on-demand basis.
+ * These array elements get filled up with maps on an on-demand basis.
* Initially just set all of them to NULL.
*/
proute->child_parent_tupconv_maps =
* Re: Incorrect grammar
@ 2018-02-06 20:51 Robert Haas <robertmhaas@gmail.com>
parent: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
0 siblings, 1 reply; 6+ messages in thread
From: Robert Haas @ 2018-02-06 20:51 UTC (permalink / raw)
To: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>; +Cc: pgsql-hackers
On Tue, Feb 6, 2018 at 5:22 AM, Etsuro Fujita
<fujita.etsuro@lab.ntt.co.jp> wrote:
> While reviewing the
> lazy-initialization-of-partition-info-for-tuple-routing patch, I ran
> into a grammar mistake in a comment in ExecSetupChildParentMapForLeaf.
> Attached is a patch for fixing that.
Committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Incorrect grammar
@ 2018-02-07 10:38 Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
parent: Robert Haas <robertmhaas@gmail.com>
0 siblings, 0 replies; 6+ messages in thread
From: Etsuro Fujita @ 2018-02-07 10:38 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: pgsql-hackers
(2018/02/07 5:51), Robert Haas wrote:
> On Tue, Feb 6, 2018 at 5:22 AM, Etsuro Fujita
> <fujita.etsuro@lab.ntt.co.jp> wrote:
>> While reviewing the
>> lazy-initialization-of-partition-info-for-tuple-routing patch, I ran
>> into a grammar mistake in a comment in ExecSetupChildParentMapForLeaf.
>> Attached is a patch for fixing that.
>
> Committed.
Thank you.
Best regards,
Etsuro Fujita
^ permalink raw reply [nested|flat] 6+ messages in thread
* Incorrect grammar
@ 2018-02-22 11:54 Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
0 siblings, 1 reply; 6+ messages in thread
From: Etsuro Fujita @ 2018-02-22 11:54 UTC (permalink / raw)
To: pgsql-hackers
Here is a tiny patch to fix $SUBJECT in a comment in execPartition.c.
Best regards,
Etsuro Fujita
Attachments:
execPartition-comment-fix.patch (text/x-diff, 847B) download
diff --git a/src/backend/executor/execPartition.c b/src/backend/executor/execPartition.c
index 4048c3e..882b538 100644
--- a/src/backend/executor/execPartition.c
+++ b/src/backend/executor/execPartition.c
@@ -140,10 +140,10 @@ ExecSetupPartitionTupleRouting(ModifyTableState *mtstate,
partrel = leaf_part_rri->ri_RelationDesc;
/*
- * This is required in order to we convert the partition's
- * tuple to be compatible with the root partitioned table's
- * tuple descriptor. When generating the per-subplan result
- * rels, this was not set.
+ * This is required in order to convert the partition's tuple
+ * to be compatible with the root partitioned table's tuple
+ * descriptor. When generating the per-subplan result rels,
+ * this was not set.
*/
leaf_part_rri->ri_PartitionRoot = rel;
* Re: Incorrect grammar
@ 2018-02-22 15:09 Robert Haas <robertmhaas@gmail.com>
parent: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
0 siblings, 1 reply; 6+ messages in thread
From: Robert Haas @ 2018-02-22 15:09 UTC (permalink / raw)
To: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>; +Cc: pgsql-hackers
On Thu, Feb 22, 2018 at 6:54 AM, Etsuro Fujita
<fujita.etsuro@lab.ntt.co.jp> wrote:
> Here is a tiny patch to fix $SUBJECT in a comment in execPartition.c.
Committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Incorrect grammar
@ 2018-02-23 02:09 Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
parent: Robert Haas <robertmhaas@gmail.com>
0 siblings, 0 replies; 6+ messages in thread
From: Etsuro Fujita @ 2018-02-23 02:09 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: pgsql-hackers
(2018/02/23 0:09), Robert Haas wrote:
> On Thu, Feb 22, 2018 at 6:54 AM, Etsuro Fujita
> <fujita.etsuro@lab.ntt.co.jp> wrote:
>> Here is a tiny patch to fix $SUBJECT in a comment in execPartition.c.
>
> Committed.
Thanks!
Best regards,
Etsuro Fujita
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2018-02-23 02:09 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-02-06 10:22 Incorrect grammar Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
2018-02-06 20:51 ` Robert Haas <robertmhaas@gmail.com>
2018-02-07 10:38 ` Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
2018-02-22 11:54 Incorrect grammar Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
2018-02-22 15:09 ` Robert Haas <robertmhaas@gmail.com>
2018-02-23 02:09 ` Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox