agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
To: Pavan Deolasee <pavan.deolasee@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: ON CONFLICT DO UPDATE for partitioned tables
Date: Fri, 16 Mar 2018 20:43:30 +0900
Message-ID: <5AABADE2.3040805@lab.ntt.co.jp> (raw)
In-Reply-To: <CABOikdNMqDsc9GFSvpAiWB5tm6sTTkAaozbwkRB2e2UqOQ8zsg@mail.gmail.com>
References: <3c3bbb2c-c28f-5b09-c124-b99e2231fe9b@lab.ntt.co.jp>
<20180302153610.2yl4j2wmpw7mntge@alvherre.pgsql>
<CABOikdNMqDsc9GFSvpAiWB5tm6sTTkAaozbwkRB2e2UqOQ8zsg@mail.gmail.com>
(2018/03/16 19:43), Pavan Deolasee wrote:
> On Fri, Mar 2, 2018 at 9:06 PM, Alvaro Herrera <alvherre@2ndquadrant.com
> <mailto:alvherre@2ndquadrant.com>> wrote:
> @@ -106,6 +120,9 @@ typedef struct PartitionTupleRouting
> int num_subplan_partition_offsets;
> TupleTableSlot *partition_tuple_slot;
> TupleTableSlot *root_tuple_slot;
> + List **partition_arbiter_indexes;
> + TupleTableSlot **partition_conflproj_slots;
> + TupleTableSlot **partition_existing_slots;
> } PartitionTupleRouting;
> I am curious why you decided to add these members to
> PartitionTupleRouting structure. Wouldn't ResultRelationInfo be a better
> place to track these or is there some rule that we follow?
I just started reviewing the patch, so maybe I'm missing something, but
I think it would be a good idea to have these in that structure, not in
ResultRelInfo, because these would be required only for partitions
chosen via tuple routing.
Best regards,
Etsuro Fujita
view thread (53+ messages) latest in thread
Message-ID: <5AABADE2.3040805@lab.ntt.co.jp>
Permalink: ../5AABADE2.3040805@lab.ntt.co.jp/
Also on: postgresql.org/message-id/5AABADE2.3040805@lab.ntt.co.jp
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: fujita.etsuro@lab.ntt.co.jp, pavan.deolasee@gmail.com, alvherre@2ndquadrant.com, Langote_Amit_f8@lab.ntt.co.jp
Subject: Re: ON CONFLICT DO UPDATE for partitioned tables
In-Reply-To: <5AABADE2.3040805@lab.ntt.co.jp>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox