From: Chapman Flack <chap@anastigmatix.net>
To: Michael Paquier <michael@paquier.xyz>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Markus Winand <markus.winand@winand.at>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: PostgreSQL vs SQL/XML Standards
Date: Tue, 5 Feb 2019 23:16:49 -0500
Message-ID: <5C5A5FB1.5010408@anastigmatix.net> (raw)
In-Reply-To: <20190202012008.GF11299@paquier.xyz>
References: <5C449C71.7060903@anastigmatix.net>
<CAFj8pRAabQWW13FS58fj1h6YxKsbhEaegRctf28TFeheWGn_3A@mail.gmail.com>
<5C44B332.6070609@anastigmatix.net>
<CAFj8pRAfjUJZX3so2TooQvag2C+5b1+sm4rzZuJkuO5UtDtkhg@mail.gmail.com>
<5C44F26D.5010703@anastigmatix.net>
<CAFj8pRCLXAU5wsdLksh4z8_2Sz5baVM9HOZntG1UqQ9tGrjkPQ@mail.gmail.com>
<5C4A94A5.8010402@anastigmatix.net>
<CAFj8pRAgWyDrLZJ9pUf7E-yqpR85RpGNtAP+PxEzSCOegwZjQA@mail.gmail.com>
<5C4BABDC.4010600@anastigmatix.net>
<CAFj8pRBXLi16JKea5=8WQ9zeFX7uVpbi3u17rTtV5+MhsbT7MQ@mail.gmail.com>
<20190202012008.GF11299@paquier.xyz>
On 02/01/19 20:20, Michael Paquier wrote:
> On Thu, Jan 31, 2019 at 04:26:31PM +0100, Pavel Stehule wrote:
>> I'll mark this patch as ready for commiters.
>
> For now I have moved the patch to the next CF, with the same status.
I wonder whether, given the move to next CF, it makes sense to change
the title of the CF entry from "XMLTABLE" to, more generically, XML
improvements, and get one or two more small changes in:
- get XMLPARSE(CONTENT... (and cast-to-xml with XMLOPTION=content) to
succeed even for content with DTDs, so that the content subtype really
does fully include the document subtype, aligning it with the SQL:2006+
standard. I think this would be a simple patch that I can deliver early
this month, and Tom found reports where the current behavior already
bites people in pg_restore. Its only effect would be to allow a currently-
failing case to succeed (and stop biting people).
- get XMLEXISTS and XMLTABLE to allow passing of named parameters. I have
less of a sense of how difficult that might be, but I see that the libxml
xpath API does allow them. I don't know whether they were left out of the
original development just arbitrarily, or whether some effort was made
and ran into some problem.
The value of supporting the named parameters, especially when the library
limits us to XPath 1.0, is that the XPath 1.0 limitation that a value
passed as the context item can only be an XML 'document' only applies to
the context item, not to named parameters. So if somebody is trying to
port an expression ...'foo(.)' PASSING bar... and bar is not in document
form, there's a simple rewrite to ...'foo($a) PASSING bar AS a...
whereas if we can't do named parameters, frustration ensues.
Again, the only effect of such a change would be to permit something that
currently isn't possible. I don't think I can promise to work on a patch
for the second issue, but they both seem worthwhile, and I'm happy to
work on the first.
It seems to me these changes and the doc patch to go with them are
closely enough related to fit in one CF entry that's still smaller and
simpler than many, and that shouldn't be too difficult to review for v12,
but I'll defer to more experienced voices.
Regards,
-Chap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: chap@anastigmatix.net, michael@paquier.xyz, pavel.stehule@gmail.com, pgsql-hackers@lists.postgresql.org, markus.winand@winand.at, alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us
Subject: Re: PostgreSQL vs SQL/XML Standards
In-Reply-To: <5C5A5FB1.5010408@anastigmatix.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox