pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Problems with plan estimates in postgres_fdw
Date: Wed, 06 Mar 2019 22:03:18 +0900
Message-ID: <5C7FC516.10100@lab.ntt.co.jp> (raw)
In-Reply-To: <5C6FB014.9040403@lab.ntt.co.jp>
References: <87pnz1aby9.fsf@news-spur.riddles.org.uk>
	<1175.1533220908@sss.pgh.pa.us>
	<5BB739CD.6040002@lab.ntt.co.jp>
	<5BBC4140.50403@lab.ntt.co.jp>
	<5C17A00E.5000005@lab.ntt.co.jp>
	<5C232F39.9060509@lab.ntt.co.jp>
	<5C25C7B5.2010802@lab.ntt.co.jp>
	<5C518631.5080401@lab.ntt.co.jp>
	<CAMkU=1z1Ez7fb_P_0Bc1040npE5fCOnu0M1DFyOzCp=e=rBJCw@mail.gmail.com>
	<5C6FB014.9040403@lab.ntt.co.jp>

(2019/02/22 17:17), Etsuro Fujita wrote:
> (2019/02/21 6:19), Jeff Janes wrote:

>> With your tweaks, I'm still not seeing the ORDER-less LIMIT get pushed
>> down when using use_remote_estimate in a simple test case, either with
>> this set of patches, nor in the V4 set. However, without
>> use_remote_estimate, the LIMIT is now getting pushed with these patches
>> when it does not in HEAD.
>
> Good catch! I think the root cause of that is: when using
> use_remote_estimate, remote estimates obtained through remote EXPLAIN
> are rounded off to two decimal places, which I completely overlooked.
> Will fix. I think I can post a new version early next week.

Done.  Please see [1].  Sorry for the delay.

Best regards,
Etsuro Fujita

[1] https://www.postgresql.org/message-id/5C7FC458.4020400%40lab.ntt.co.jp





view thread (48+ messages)  latest in thread

Message-ID: <5C7FC516.10100@lab.ntt.co.jp>
Permalink:  ../5C7FC516.10100@lab.ntt.co.jp/
Also on:    postgresql.org/message-id/5C7FC516.10100@lab.ntt.co.jp

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: fujita.etsuro@lab.ntt.co.jp, jeff.janes@gmail.com, tgl@sss.pgh.pa.us, andrew@tao11.riddles.org.uk
  Subject: Re: Problems with plan estimates in postgres_fdw
  In-Reply-To: <5C7FC516.10100@lab.ntt.co.jp>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox