From: Chapman Flack <chap@anastigmatix.net>
To: Ryan Lambert <ryan@rustprooflabs.com>
To: pgsql-hackers@lists.postgresql.org
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Subject: Re: Fix XML handling with DOCTYPE
Date: Mon, 25 Mar 2019 18:52:06 -0400
Message-ID: <5C995B96.6050204@anastigmatix.net> (raw)
In-Reply-To: <155355138978.16482.2985962575775445194.pgcf@coridan.postgresql.org>
References: <CAN-V+g-6JqUQEQZ55Q3toXEN6d5Ez5uvzL4VR+8KtvJKj31taw@mail.gmail.com>
<CAN-V+g9wHCQNy4aoUC9=2xzDazYoAars1VzG5_zMKa=RjGFuMA@mail.gmail.com>
<155355138978.16482.2985962575775445194.pgcf@coridan.postgresql.org>
On 03/25/19 18:03, Ryan Lambert wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: not tested
> Documentation: not tested
Hi,
Thanks for the review! Yes, that part of this commitfest entry has been
committed already and will appear in the next minor releases of those
branches.
That leaves only one patch in this commitfest entry that is still in
need of review, namely the update to the documentation.
If you happened to feel moved to look over a documentation patch, that
would be what this CF entry most needs in the waning days of the commitfest.
There seem to be community members reluctant to review it because of not
feeling sufficiently expert in XML to scrutinize every technical detail,
but there are other valuable angles for documentation review. (And the
reason there *is* a documentation patch is the plentiful room for
improvement in the documentation that's already there, so as far as
reviewing goes, the old yarn about the two guys, the running shoes, and
the bear comes to mind.)
I can supply pointers to specs, etc., for anyone who does see some technical
details in the patch and has questions about them.
Regards,
-Chap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: chap@anastigmatix.net, ryan@rustprooflabs.com, pgsql-hackers@lists.postgresql.org, pavel.stehule@gmail.com
Subject: Re: Fix XML handling with DOCTYPE
In-Reply-To: <5C995B96.6050204@anastigmatix.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox