From: Chapman Flack <chap@anastigmatix.net>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Ryan Lambert <ryan@rustprooflabs.com>
Cc: pgsql-hackers@lists.postgresql.org, Pavel Stehule <pavel.stehule@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: Fix XML handling with DOCTYPE
Date: Wed, 27 Mar 2019 19:27:23 -0400
Message-ID: <5C9C06DB.6090901@anastigmatix.net> (raw)
In-Reply-To: <5C9C023F.5070002@anastigmatix.net>
References: <20190327133152.GA7791@alvherre.pgsql>
<5C9C023F.5070002@anastigmatix.net>
On 03/27/19 19:07, Chapman Flack wrote:
> xml-functions-type-docfix-5.patch attached, with node-sets instead of
> nodesets, libxml2 instead of libxml, and parenthesized full sentences
> now au naturel.
>
> I ended up turning the formerly-parenthesized note about libxml2's
> node-set ordering into a DocBook <note>: there is really something
> parenthetical about it, with the official statement of node-set
> element ordering being that there is none, and the description of
> what the library happens to do being of possible interest, but set
> apart, with the necessary caveats about relying on it.
I have just suffered a giant sinking feeling upon re-reading this
sentence in our XMLTABLE doc:
A column marked FOR ORDINALITY will be populated with row numbers
matching the order in which the output rows appeared in the original
input XML document.
I've been skimming right over it all this time, and that right there is
a glaring built-in reliance on the observable-but-disclaimed iteration
order of a libxml2 node-set.
I'm a bit unsure what any clarifying language should even say.
Regards,
-Chap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: chap@anastigmatix.net, alvherre@2ndquadrant.com, ryan@rustprooflabs.com, pavel.stehule@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: Fix XML handling with DOCTYPE
In-Reply-To: <5C9C06DB.6090901@anastigmatix.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox