pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Jacob Champion <pchampion@vmware.com>
To: michael@paquier.xyz <michael@paquier.xyz>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Pull general SASL framework out of SCRAM
Date: Fri, 9 Jul 2021 23:31:48 +0000
Message-ID: <5a75d91c1e06cce43ba038ccaa8bfded5cb35df2.camel@vmware.com> (raw)
In-Reply-To: <YOao1wTwiWFsgL4p@paquier.xyz>
References: <3d2a6f5d50e741117d6baf83eb67ebf1a8a35a11.camel@vmware.com>
	<YNLlBncQGBIAMWho@paquier.xyz>
	<9dc553fe86ba34bff1e0b636c493b527fc7bc030.camel@vmware.com>
	<YNZ5Bqq4GvhNvbp0@paquier.xyz>
	<0907fda41fb40b23e2cbdf7eb05a8d61dd5307b3.camel@vmware.com>
	<YOLAIngluq5wOmgE@paquier.xyz>
	<39a6bd825fd776f5f9c3a8eb7ca1c62f77cea433.camel@vmware.com>
	<YOU2xFL/WoHl6ny0@paquier.xyz>
	<5cf3c71d51a215d4103abcc686c69e79619e7b60.camel@vmware.com>
	<YOao1wTwiWFsgL4p@paquier.xyz>

On Thu, 2021-07-08 at 16:27 +0900, Michael Paquier wrote:
> I agree that this looks like an improvement in terms of the
> expectations behind a SASL mechanism, so I have done the attached to
> strengthen a bit all those checks.  However, I don't really see a
> point in back-patching any of that, as SCRAM satisfies with its
> implementation already all those conditions AFAIK.

Agreed.

> Thoughts?

LGTM, thanks!

> +	 *	outputlen: The length (0 or higher) of the client response buffer,
> +	 *			   invalid if output is NULL.

nitpick: maybe "ignored" instead of "invalid"?

--Jacob


view thread (19+ messages)  latest in thread

Message-ID: <5a75d91c1e06cce43ba038ccaa8bfded5cb35df2.camel@vmware.com>
Permalink:  ../5a75d91c1e06cce43ba038ccaa8bfded5cb35df2.camel@vmware.com/
Also on:    postgresql.org/message-id/5a75d91c1e06cce43ba038ccaa8bfded5cb35df2.camel@vmware.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pchampion@vmware.com, michael@paquier.xyz
  Subject: Re: [PATCH] Pull general SASL framework out of SCRAM
  In-Reply-To: <5a75d91c1e06cce43ba038ccaa8bfded5cb35df2.camel@vmware.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox