agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Bryan Green <dbryan.green@gmail.com>
To: Álvaro Herrera <alvherre@kurilemu.de>
To: Jakub Wartak <jakub.wartak@enterprisedb.com>
Cc: Euler Taveira <euler@eulerto.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Add Windows support for backtrace_functions (MSVC only)
Date: Thu, 30 Oct 2025 03:40:06 -0600
Message-ID: <5b4c6ce0-ed17-4abb-9127-859cc95cbdf3@gmail.com> (raw)
In-Reply-To: <202510300932.isdvgkzqzshk@alvherre.pgsql>
References: <202510300932.isdvgkzqzshk@alvherre.pgsql>
On 10/30/2025 3:37 AM, Álvaro Herrera wrote:
> On 2025-Oct-30, Jakub Wartak wrote:
>
>> Hi Bryan, cfbot is red. I'm was fan of having those tests for this
>> (bring complexity and we didn't have tests for Linux backtrace
>> anyway), but now MINGW win32 is failing on those tests where the
>> feature is not present:
>
> I hate to say this after the code is written, but I think we should not
> put any tests in the first step. I predict that these are going to be
> enormously brittle and that we'll waste a lot of time making them
> stable. I think we should commit the Windows support for backtraces
> first, then consider whether we actually want TAP tests for the overall
> feature. We've gone several years with glibc backtrace support without
> any tests -- why do we think the Windows implementation thereof _must_
> necessarily have them?
>
It will not bother me to remove them. It was my first effort at writing
TAP tests, so it was a nice learning experience.
view thread (36+ messages) latest in thread
Message-ID: <5b4c6ce0-ed17-4abb-9127-859cc95cbdf3@gmail.com>
Permalink: ../5b4c6ce0-ed17-4abb-9127-859cc95cbdf3@gmail.com/
Also on: postgresql.org/message-id/5b4c6ce0-ed17-4abb-9127-859cc95cbdf3@gmail.com
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: dbryan.green@gmail.com, alvherre@kurilemu.de, jakub.wartak@enterprisedb.com, euler@eulerto.com, michael@paquier.xyz
Subject: Re: [PATCH] Add Windows support for backtrace_functions (MSVC only)
In-Reply-To: <5b4c6ce0-ed17-4abb-9127-859cc95cbdf3@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox