public inbox for [email protected]  

help / color / mirror / Atom feed

From: Long Song <[email protected]>
To: Kyotaro Horiguchi <[email protected]>
Cc: [email protected]
Subject: Re:Re: [PATCH]A minor improvement to the error-report in SimpleLruWriteAll()
Date: Tue, 4 Jun 2024 18:03:17 +0800 (CST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

Hi Kyotaro,
Thank you for the response.



At 2024-06-04 14:44:09, "Kyotaro Horiguchi" <[email protected]> wrote:
>At Tue, 28 May 2024 20:15:59 +0800 (CST), "Long Song" <[email protected]> wrote in 
>> 
>> Hi,
>> Actually, I still wonder why only the error message
>> of the last failure to close the file was recorded.
>> For this unusual situation, it is acceptable to
>> record all failure information without causing
>> too much logging.
>> Was it designed that way on purpose?
>
>Note that SlruReportIOError() causes a non-local exit. To me, the
>point of the loop seems to be that we want to close every single file,
>apart from the failed ones. From that perspective, the patch disrupts
>that intended behavior by exiting in the middle of the loop. It seems
>we didn't want to bother collecting errors for every failed file in
>that part.

Yeah, thanks for your reminder.
It was my mistake not to notice the ereport() exit in the function.
But is it necessary to record it in a log? If there is a benefit to
logging, I can submit a modified patch and record the necessary
failure information into the log in another way.

> 
>regards.
>
>-- 
>Kyotaro Horiguchi
>NTT Open Source Software Center












--
Best Regards,

Long

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re:Re: [PATCH]A minor improvement to the error-report in SimpleLruWriteAll()
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox