public inbox for [email protected]help / color / mirror / Atom feed
[PATCH 08/18] *an exclusive 3+ messages / 3 participants [nested] [flat]
* [PATCH 08/18] *an exclusive @ 2021-02-06 21:13 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Justin Pryzby @ 2021-02-06 21:13 UTC (permalink / raw) 3c84046490bed3c22e0873dc6ba492e02b8b9051 --- doc/src/sgml/ref/drop_index.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/ref/drop_index.sgml b/doc/src/sgml/ref/drop_index.sgml index 85cf23bca2..b6d2c2014f 100644 --- a/doc/src/sgml/ref/drop_index.sgml +++ b/doc/src/sgml/ref/drop_index.sgml @@ -45,7 +45,7 @@ DROP INDEX [ CONCURRENTLY ] [ IF EXISTS ] <replaceable class="parameter">name</r <para> Drop the index without locking out concurrent selects, inserts, updates, and deletes on the index's table. A normal <command>DROP INDEX</command> - acquires exclusive lock on the table, blocking other accesses until the + acquires an exclusive lock on the table, blocking other accesses until the index drop can be completed. With this option, the command instead waits until conflicting transactions have completed. </para> -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0009-Doc-review-for-psql-dX.patch" ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [PATCH]A minor improvement to the error-report in SimpleLruWriteAll() @ 2024-06-04 07:44 Kyotaro Horiguchi <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Kyotaro Horiguchi @ 2024-06-04 07:44 UTC (permalink / raw) To: [email protected]; +Cc: pgsql-hackers At Tue, 28 May 2024 20:15:59 +0800 (CST), "Long Song" <[email protected]> wrote in > > Hi, > Actually, I still wonder why only the error message > of the last failure to close the file was recorded. > For this unusual situation, it is acceptable to > record all failure information without causing > too much logging. > Was it designed that way on purpose? Note that SlruReportIOError() causes a non-local exit. To me, the point of the loop seems to be that we want to close every single file, apart from the failed ones. From that perspective, the patch disrupts that intended behavior by exiting in the middle of the loop. It seems we didn't want to bother collecting errors for every failed file in that part. regards. -- Kyotaro Horiguchi NTT Open Source Software Center ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re:Re: [PATCH]A minor improvement to the error-report in SimpleLruWriteAll() @ 2024-06-04 10:03 Long Song <[email protected]> parent: Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Long Song @ 2024-06-04 10:03 UTC (permalink / raw) To: Kyotaro Horiguchi <[email protected]>; +Cc: pgsql-hackers Hi Kyotaro, Thank you for the response. At 2024-06-04 14:44:09, "Kyotaro Horiguchi" <[email protected]> wrote: >At Tue, 28 May 2024 20:15:59 +0800 (CST), "Long Song" <[email protected]> wrote in >> >> Hi, >> Actually, I still wonder why only the error message >> of the last failure to close the file was recorded. >> For this unusual situation, it is acceptable to >> record all failure information without causing >> too much logging. >> Was it designed that way on purpose? > >Note that SlruReportIOError() causes a non-local exit. To me, the >point of the loop seems to be that we want to close every single file, >apart from the failed ones. From that perspective, the patch disrupts >that intended behavior by exiting in the middle of the loop. It seems >we didn't want to bother collecting errors for every failed file in >that part. Yeah, thanks for your reminder. It was my mistake not to notice the ereport() exit in the function. But is it necessary to record it in a log? If there is a benefit to logging, I can submit a modified patch and record the necessary failure information into the log in another way. > >regards. > >-- >Kyotaro Horiguchi >NTT Open Source Software Center -- Best Regards, Long ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-06-04 10:03 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-02-06 21:13 [PATCH 08/18] *an exclusive Justin Pryzby <[email protected]> 2024-06-04 07:44 Re: [PATCH]A minor improvement to the error-report in SimpleLruWriteAll() Kyotaro Horiguchi <[email protected]> 2024-06-04 10:03 ` Re:Re: [PATCH]A minor improvement to the error-report in SimpleLruWriteAll() Long Song <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox