From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: amcheck: Remove unused IndexCheckableCallback typedef
Date: Fri, 4 Jul 2025 23:29:35 +0900
Message-ID: <5c3ebd10-9773-440d-93ae-d5f737827ca1@oss.nttdata.com> (raw)
In-Reply-To: <4CBF8299-22E1-4CF8-80B0-32EEF8223911@yandex-team.ru>
References: <e1ea4e14-3b21-4e01-a5f2-0686883265df@oss.nttdata.com>
<4CBF8299-22E1-4CF8-80B0-32EEF8223911@yandex-team.ru>
On 2025/07/04 17:25, Andrey Borodin wrote:
>
>
>> On 4 Jul 2025, at 10:50, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>
>> From the discussion in [1], it seems this typedef was originally used as
>> a function argument in early versions of the patch. However,
>> the argument was removed in v23, and the typedef was accidentally left behind.
>
> Yes, your analysis is correct. We could make common checking function and argument was not needed.
>
>>
>> The attached patch removes this unused typedef to clean up the dead code.
>> Thoughts?
>
> Looks good to me. Thanks for fixing this!
Thanks for the review! I've pushed the patch.
Regards,
--
Fujii Masao
NTT DATA Japan Corporation
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: masao.fujii@oss.nttdata.com, x4mmm@yandex-team.ru, pgsql-hackers@lists.postgresql.org
Subject: Re: amcheck: Remove unused IndexCheckableCallback typedef
In-Reply-To: <5c3ebd10-9773-440d-93ae-d5f737827ca1@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox