From: Vik Fearing <vik@postgresfriends.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Dian M Fay <dian.m.fay@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: TRIM_ARRAY
Date: Wed, 3 Mar 2021 23:03:46 +0100
Message-ID: <5d4074b7-f844-e52c-2b3b-833f2d334a69@postgresfriends.org> (raw)
In-Reply-To: <1249311.1614808037@sss.pgh.pa.us>
References: <C9MFB04FWKBB.13JGHNUNS5Z4R@lamia>
<6565ca98-6733-532a-2130-752545bab6b5@postgresfriends.org>
<1249311.1614808037@sss.pgh.pa.us>
On 3/3/21 10:47 PM, Tom Lane wrote:
>
> I had the same problem as Dian of the func.sgml hunk winding up in
> the wrong place. I think this is practically inevitable unless the
> submitter uses more than 3 lines of context for the diff, because
> otherwise the context is just boilerplate that looks the same
> everywhere in the function tables. Unless the diff is 100% up to date
> so that the line numbers are exactly right, patch is likely to guess
> wrong about where to insert the new hunk. We'll just have to be
> vigilant about that.
Noted.
> I fooled with your test case a bit ... I didn't think it was really
> necessary to create and drop a table, when we could just use a VALUES
> clause as source of test data. Also you'd forgotten to update the
> "descr" description of the function to match the final understanding
> of the semantics.
Thank you.
> Looks good otherwise, so pushed.
Thanks!
--
Vik Fearing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: vik@postgresfriends.org, tgl@sss.pgh.pa.us, dian.m.fay@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: TRIM_ARRAY
In-Reply-To: <5d4074b7-f844-e52c-2b3b-833f2d334a69@postgresfriends.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox