public inbox for [email protected]
help / color / mirror / Atom feedFrom: Peter Eisentraut <[email protected]>
To: Tom Lane <[email protected]>
Cc: David Rowley <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: automatically generating node support functions
Date: Fri, 8 Jul 2022 17:46:28 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<CAApHDvppoxUxzRJbwF9oOF12ngdfNoPEMfDsu63+LREgGnheUw@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<b9acf63c-6693-d87c-f010-ca8ad502a39f@enterp! risedb.com>
<[email protected]>
On 08.07.22 15:52, Tom Lane wrote:
> I'll re-read the patch today, but how open are you to putting the
> struct attributes at the top? I'm willing to do the legwork.
I agree near the top would be preferable. I think it would even be
feasible to parse the whole thing if pgindent split it across lines. I
sort of tried to maintain the consistency with C/C++ attributes like
__attribute__ and [[attribute]], hoping that that would confuse other
tooling the least. Feel free to experiment further.
view thread (80+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: automatically generating node support functions
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox