pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Joe Conway <mail@joeconway.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Joshua Brindle <joshua.brindle@crunchydata.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Bossart, Nathan <bossartn@amazon.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH v2] use has_privs_for_role for predefined roles
Date: Thu, 10 Feb 2022 14:37:06 -0500
Message-ID: <6135d0b7-3af9-d6fa-cdaa-990a2fc12147@joeconway.com> (raw)
In-Reply-To: <20220210192829.GB1684442@nathanxps13>
References: <80af9ba7-ec24-9134-8fd9-00bf13f5c494@joeconway.com>
	<CA+TgmoY7Hy2iiJ6SKPKjG9w4D+KiPYtZoXB=PpX2oQkwcK5rUw@mail.gmail.com>
	<18eab9b6-1f77-72b2-83d3-1856c17f3fcb@joeconway.com>
	<CA+Tgmoa-czkhuLM6ZGKsTTxM56k4Ba2=_2Ai5Uo-u+PSkRVNww@mail.gmail.com>
	<CAGB+Vh5h29oiq=paMPoz_f8rAOhF0AFkAup6Wo2+td=JJ+8Brw@mail.gmail.com>
	<CA+TgmoaGoWYcPX-T0uAheAfrwcvnLUw8N2FsC7TvqQku-qvJUQ@mail.gmail.com>
	<0b1b6cfb-d752-28f6-7ccb-993998be0189@joeconway.com>
	<CA+TgmoYhx2KtBKX6Na-050RS5x5O_=arTzA96VmJd7=6hGBtag@mail.gmail.com>
	<20220209181333.GD1627503@nathanxps13>
	<e2955bbc-f7f4-cb80-d35a-ff754898bab0@joeconway.com>
	<20220210192829.GB1684442@nathanxps13>

On 2/10/22 14:28, Nathan Bossart wrote:
> On Wed, Feb 09, 2022 at 04:39:11PM -0500, Joe Conway wrote:
>> On 2/9/22 13:13, Nathan Bossart wrote:
>>> I do wonder if users find the differences between predefined roles and role
>>> attributes confusing.  INHERIT doesn't govern role attributes, but it will
>>> govern predefined roles when this patch is applied.  Maybe the role
>>> attribute system should eventually be deprecated in favor of using
>>> predefined roles for everything.  Or perhaps the predefined roles should be
>>> converted to role attributes.
>> 
>> Yep, I was suggesting that the latter would have been preferable to me while
>> Robert seemed to prefer the former. Honestly I could be happy with either of
>> those solutions, but as I alluded to that is probably a discussion for the
>> next development cycle since I don't see us doing that big a change in this
>> one.
> 
> I agree.  I still think Joshua's proposed patch is a worthwhile improvement
> for v15.

+1

I am planning to get into it in detail this weekend. So far I have 
really just ensured it merges cleanly and passes make world.

Joe
-- 
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development





view thread (42+ messages)  latest in thread

Message-ID: <6135d0b7-3af9-d6fa-cdaa-990a2fc12147@joeconway.com>
Permalink:  ../6135d0b7-3af9-d6fa-cdaa-990a2fc12147@joeconway.com/
Also on:    postgresql.org/message-id/6135d0b7-3af9-d6fa-cdaa-990a2fc12147@joeconway.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: mail@joeconway.com, nathandbossart@gmail.com, robertmhaas@gmail.com, joshua.brindle@crunchydata.com, tgl@sss.pgh.pa.us, bossartn@amazon.com, sfrost@snowman.net
  Subject: Re: [PATCH v2] use has_privs_for_role for predefined roles
  In-Reply-To: <6135d0b7-3af9-d6fa-cdaa-990a2fc12147@joeconway.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox