public inbox for [email protected]  

help / color / mirror / Atom feed

From: Chapman Flack <[email protected]>
To: [email protected]
Subject: Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file
Date: Sat, 26 Feb 2022 17:03:04 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <164589413251.1035.2695761148079719188.pgcf@coridan.postgresql.org>
References: <CAHg+QDfiM+WU61tF6=nPZocMZvHDzCK47Kneyb0ZRULYzV5sKQ@mail.gmail.com>
	<20220221172306.GA3698472@nathanxps13>
	<164589413251.1035.2695761148079719188.pgcf@coridan.postgresql.org>

On 02/26/22 11:48, Chapman Flack wrote:
> This patch applies cleanly for me and passes installcheck-world.
> I have not yet studied all of the changes in detail.

I've now looked through the rest, and the only further thing I noticed
was that xlog.c's do_pg_start_backup still has a tablespaces parameter
to receive a List* of tablespaces if the caller wants, but this patch
removes the comment describing it:


- * If "tablespaces" isn't NULL, it receives a list of tablespaceinfo structs
- * describing the cluster's tablespaces.


which seems like collateral damage.

Regards,
-Chap

view thread (14+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox