pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Richard Guo <guofenglinux@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Wrong results from Parallel Hash Full Join
Date: Fri, 19 May 2023 20:04:58 -0400
Message-ID: <623596.1684541098@sss.pgh.pa.us> (raw)
In-Reply-To: <ZEFfVUeNzQaeHy7R@telsasoft.com>
References: <20230412181452.cyfduw2ka2atqmii@awork3.anarazel.de>
	<CAAKRu_Z=rzXjxVtA7gPe2bmBk7F6e4_pe8iT5DmnYFOgWPxMGQ@mail.gmail.com>
	<CAAKRu_Ybw_0MDNTW_jg3gndXs7F6H8MUZkbY2iMtSHeS5L97hw@mail.gmail.com>
	<CA+hUKGKuLORE0OQ20sFrfdp=5tKVvamB-FnnCS03UZE+o8UFjQ@mail.gmail.com>
	<CAAKRu_av+NCVPXkLLTBG2VZcAk83FrzR9z-kZ-NQ+1kai9Tibw@mail.gmail.com>
	<20230419151704.xkkobswffutslj34@liskov>
	<ZEAh6CewmARbDVuN@telsasoft.com>
	<20230419192051.xkgyj76akczpbjbs@awork3.anarazel.de>
	<ZECKP5NwoDGT3+RN@telsasoft.com>
	<CAAKRu_YFUC+Sh9969RJ7GCSX=nPOQLVJp9UHK_iHtVT=wkBEKQ@mail.gmail.com>
	<ZEFfVUeNzQaeHy7R@telsasoft.com>

I noticed that BF animal conchuela has several times fallen over on the
test case added by 558c9d75f:

inline patch 1: /home/pgbf/buildroot/HEAD/pgsql.build/src/test/regress/results/join_hash.out (+1/-1 lines) download inline-1.patchdiff -U3 /home/pgbf/buildroot/HEAD/pgsql.build/src/test/regress/expected/join_hash.out /home/pgbf/buildroot/HEAD/pgsql.build/src/test/regress/results/join_hash.out --- /home/pgbf/buildroot/HEAD/pgsql.build/src/test/regress/expected/join_hash.out 2023-04-19 10:20:26.159840000 +0200 +++ /home/pgbf/buildroot/HEAD/pgsql.build/src/test/regress/results/join_hash.out 2023-04-19 10:21:47.971900000 +0200 @@ -974,8 +974,8 @@ SELECT * FROM hjtest_matchbits_t1 t1 FULL JOIN hjtest_matchbits_t2 t2 ON t1.id = t2.id; id | id ----+---- - 1 | | 2 + 1 | (2 rows) -- Test serial full hash join.
Considering that this is a parallel plan, I don't think there's any mystery about why an ORDER-BY-less query might have unstable output order; the only mystery is why more of the buildfarm hasn't failed. Can we just add "ORDER BY t1.id" to this query? It looks like you get the same PHJ plan, although now underneath Sort/Gather Merge. regards, tom lane [1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=conchuela&dt=2023-04-19%2008%3A20%3A56 [2] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=conchuela&dt=2023-05-03%2006%3A21%3A03 [3] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=conchuela&dt=2023-05-19%2022%3A21%3A04

view thread (22+ messages)  latest in thread

Message-ID: <623596.1684541098@sss.pgh.pa.us>
Permalink:  ../623596.1684541098@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/623596.1684541098@sss.pgh.pa.us

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, melanieplageman@gmail.com, andres@anarazel.de, thomas.munro@gmail.com, guofenglinux@gmail.com
  Subject: Re: Wrong results from Parallel Hash Full Join
  In-Reply-To: <623596.1684541098@sss.pgh.pa.us>
  References: <20230412181452.cyfduw2ka2atqmii@awork3.anarazel.de> <CAAKRu_Z=rzXjxVtA7gPe2bmBk7F6e4_pe8iT5DmnYFOgWPxMGQ@mail.gmail.com> <CAAKRu_Ybw_0MDNTW_jg3gndXs7F6H8MUZkbY2iMtSHeS5L97hw@mail.gmail.com> <CA+hUKGKuLORE0OQ20sFrfdp=5tKVvamB-FnnCS03UZE+o8UFjQ@mail.gmail.com> <CAAKRu_av+NCVPXkLLTBG2VZcAk83FrzR9z-kZ-NQ+1kai9Tibw@mail.gmail.com> <20230419151704.xkkobswffutslj34@liskov> <ZEAh6CewmARbDVuN@telsasoft.com> <20230419192051.xkgyj76akczpbjbs@awork3.anarazel.de> <ZECKP5NwoDGT3+RN@telsasoft.com> <CAAKRu_YFUC+Sh9969RJ7GCSX=nPOQLVJp9UHK_iHtVT=wkBEKQ@mail.gmail.com> <ZEFfVUeNzQaeHy7R@telsasoft.com> <623596.1684541098@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox