From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Peter Geoghegan <pg@heroku.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: ICU integration
Date: Mon, 9 Jan 2017 15:25:36 -0500
Message-ID: <6261dcf6-5bd1-a4ce-a800-54b34d696b3e@2ndquadrant.com> (raw)
In-Reply-To: <CAM3SWZR-ndDTEuU_p0meRARYZ0gMqmyG9gE9pR-M7qwSdTEGzA@mail.gmail.com>
References: <85364fde-091f-bbc0-fec2-e3ede39840a6@2ndquadrant.com>
<3a88fa29-275b-f547-9957-86d4b2cd68db@2ndquadrant.com>
<CAM3SWZR-ndDTEuU_p0meRARYZ0gMqmyG9gE9pR-M7qwSdTEGzA@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 1/7/17 10:01 PM, Peter Geoghegan wrote:
> It occurs to me that the comparison caching stuff added by commit
> 0e57b4d8b needs to be considered here, too. When we had to copy the
> string to a temp buffer anyway, in order to add the terminating NUL
> byte expected by strcoll(), there was an opportunity to do caching of
> comparisons at little additional cost. However, since ICU offers an
> interface that you're using that doesn't require any NUL byte, there
> is a new trade-off to be considered -- swallow the cost of copying
> into our own temp buffer solely for the benefit of comparison caching,
> or don't do comparison caching. (Note that glibc had a similar
> comparison caching optimization itself at one point, built right into
> strcoll(), but it was subsequently disabled.)
That might be worth looking into, but it seems a bit daunting to
construct a benchmark specifically for this, unless we have the one that
was originally used lying around somewhere.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, pg@heroku.com
Subject: Re: ICU integration
In-Reply-To: <6261dcf6-5bd1-a4ce-a800-54b34d696b3e@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox