From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Jeevan Chalke <jeevan.chalke@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Server crash (FailedAssertion) due to catcache refcount mis-handling
Date: Tue, 08 Aug 2017 12:26:36 -0400
Message-ID: <6299.1502209596@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+Tgmob2LxK1vdGmt_nA_B4DW7PzcZoa+Ece4_VihshUvuyoog@mail.gmail.com>
References: <CAM2+6=VEE30YtRQCZX7_sCFsEpoUkFBV1gZazL70fqLn8rcvBA@mail.gmail.com>
<4244.1502206577@sss.pgh.pa.us>
<CA+Tgmob2LxK1vdGmt_nA_B4DW7PzcZoa+Ece4_VihshUvuyoog@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Aug 8, 2017 at 11:36 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> We could respond to this by using PG_ENSURE_ERROR_CLEANUP there instead
>> of plain PG_TRY. But I have an itchy feeling that there may be a lot
>> of places with similar issues. Should we be revisiting the basic way
>> that elog(FATAL) works, to make it less unlike elog(ERROR)?
> ... Arguably, this assertion is merely overzealous; we could skip
> this processing when proc_exit_inprogress, for example.
Yeah, I thought about weakening the assertions too, but I couldn't
see a fix of that kind that didn't seem mighty ad-hoc.
Now, there is some room to argue that AtEOXact_CatCache() is just
obsolete and we should remove it altogether; I don't think it's
caught a real bug since we invented resowners in 8.1. Short of that,
though, I'm not really happy with just arbitrarily weakening the
checks.
But, again, the larger question to my mind is where else we may have
similar issues. There's certainly never been any methodical attempt
to see whether elog(FATAL) will work everywhere.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, jeevan.chalke@enterprisedb.com
Subject: Re: Server crash (FailedAssertion) due to catcache refcount mis-handling
In-Reply-To: <6299.1502209596@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox