pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Bryan Green <dbryan.green@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] O_CLOEXEC not honored on Windows - handle inheritance chain
Date: Mon, 22 Dec 2025 16:50:38 -0500
Message-ID: <634373.1766440238@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+hUKGJreZe9jzPA6jDsLLB18d7M0rvypdbV18UBMxiFxdsf2g@mail.gmail.com>
References: <e2b16375-7430-4053-bda3-5d2194ff1880@gmail.com>
	<CA+hUKGJS=xdaQ6iCTSgvBrf8Cm+a_ZMmDjZYhdQX_srHkhOuqA@mail.gmail.com>
	<7f6779d5-7a0e-44c5-a85f-b4ef265db766@gmail.com>
	<35f9236e-95d8-4f31-ac6b-ec54b7de4bac@gmail.com>
	<7412f694-7c57-41e5-ae37-71136070b0da@gmail.com>
	<CA+hUKGLX7t_PZjcUGm2-hL52RsKwof4F+-ENN5qc0AOBMPY1_g@mail.gmail.com>
	<ac7fe47b-0079-4711-9c58-73467b1d262a@gmail.com>
	<e3b982d0-c56e-441e-a5d5-61de571e313c@gmail.com>
	<CA+hUKGJh0a_6EP8NLh6jjQjzzg=Nm_h9HMC19-tBww7ZqQDWVg@mail.gmail.com>
	<CA+hUKGKbWCzBPYGKuoTG2_8uCvrKuoHkvpbjxLUYhPDiJHapNg@mail.gmail.com>
	<1086088.1765593851@sss.pgh.pa.us>
	<CA+hUKGJOVyea=EqZaMy9nt0Js10+E9y1FYL0=E_+UskZi-3wXQ@mail.gmail.com>
	<26678db0-519e-4c77-9b34-c5f94f97f6b9@gmail.com>
	<1115993.1765607595@sss.pgh.pa.us>
	<CA+hUKGJdL8sLW_xbgQ3sfBRXSTOPAsw3iFF8Cv8aTGG2kxvbLw@mail.gmail.com>
	<CA+hUKG+FRtqt0ZZVxb4e4h1gRnpECvehGB5JHqK73q8LxhbbVQ@mail.gmail.com>
	<175163.1766357334@sss.pgh.pa.us>
	<CA+hUKG+-d0OyLMdMiZ+Ftj2hhZXT+0HOyHfrPBecE_vZz! h9rRg@mail.gmail.com>
	<CA+hUKGJreZe9jzPA6jDsLLB18d7M0rvypdbV18UBMxiFxdsf2g@mail.gmail.com>

Thomas Munro <thomas.munro@gmail.com> writes:
> That revealed another problem: Mkvcbuild.pm didn't add -lpgport.  It
> looks out for the pattern PG_LIBS_INTERNAL = $(libpq_pgport), so
> that's an easy way to fix that -- is there a better way?  I couldn't
> figure out how to tell it that we need libpqport but not libpq.

AFAICT from looking at v16 Mkvcbuild.pm, PG_LIBS_INTERNAL = $(libpq_pgport)
will do exactly what you want because that only triggers it to add
libpgport and libpgcommon (cf. lines 1053ff).  I'm a little baffled
by that --- shouldn't it be pulling in libpq as well?  But let's let
sleeping dogs lie.

			regards, tom lane





view thread (25+ messages)  latest in thread

Message-ID: <634373.1766440238@sss.pgh.pa.us>
Permalink:  ../634373.1766440238@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/634373.1766440238@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, thomas.munro@gmail.com, dbryan.green@gmail.com
  Subject: Re: [PATCH] O_CLOEXEC not honored on Windows - handle inheritance chain
  In-Reply-To: <634373.1766440238@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox