From: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Teodor Sigaev <teodor@sigaev.ru>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Anastasia Lubennikova <lubennikovaav@gmail.com>
Cc: Peter Geoghegan <pg@heroku.com>
Cc: David Steele <david@pgmasters.net>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Aleksander Alekseev <a.alekseev@postgrespro.ru>
Subject: Re: WIP: Covering + unique indexes.
Date: Fri, 31 Mar 2017 21:28:10 +0300
Message-ID: <638da278-0bd3-2e10-1a6c-bb2194ffc22e@postgrespro.ru> (raw)
In-Reply-To: <CA+TgmoY7P_H9AMsFJ+oDXFXoU5gYm1VN2=U1DLjJYmf=eGowQw@mail.gmail.com>
References: <56168952.4010101@postgrespro.ru>
<46e1f13e-6887-3851-a525-f046029341eb@postgrespro.ru>
<20170324124709.22419.51178.pgcf@coridan.postgresql.org>
<c1f7c059-597f-44e8-7308-73d76ffd493c@sigaev.ru>
<20170330191138.zawsxgsxnt2qy2as@alap3.anarazel.de>
<a976fff4-29a9-c799-5c2d-19a371031325@postgrespro.ru>
<CA+TgmoY7P_H9AMsFJ+oDXFXoU5gYm1VN2=U1DLjJYmf=eGowQw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
31.03.2017 20:57, Robert Haas:
> On Fri, Mar 31, 2017 at 1:40 PM, Anastasia Lubennikova
> <a.lubennikova@postgrespro.ru> wrote:
>> First of all, I want to thank you and Robert for reviewing this patch.
>> Your expertise in postgres subsystems is really necessary for features like
>> this.
>> I just wonder, why don't you share your thoughts and doubts till the "last
>> call".
> I haven't done any significant technical work other than review
> patches in 14 months, and in the last several months I've often worked
> 10 and 12 hour days to get more review done.
>
> I think at one level you've got a fair complaint here - it's hard to
> get things committed, and this patch probably didn't get as much
> attention as it deserved. It's not so easy to know how to fix that.
> I'm pretty sure "tell Andres and Robert to work harder" isn't it.
>
*off-topic*
No complaints from me, I understand how difficult is reviewing and
highly appreciate your work.
The problem is that not all developers are qualified enough to do a review.
I've tried to make a course about postrges internals. Something like
"Deep dive into postgres codebase for hackers".
And it turned out to be really helpful for new developers. So, I wonder,
maybe we could write some tips for new reviewers and testers as well.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.lubennikova@postgrespro.ru, robertmhaas@gmail.com, andres@anarazel.de, teodor@sigaev.ru, lubennikovaav@gmail.com, pg@heroku.com, david@pgmasters.net, peter.eisentraut@2ndquadrant.com, a.alekseev@postgrespro.ru
Subject: Re: WIP: Covering + unique indexes.
In-Reply-To: <638da278-0bd3-2e10-1a6c-bb2194ffc22e@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox