public inbox for [email protected]  

help / color / mirror / Atom feed
From: Chao Li <[email protected]>
To: Laurenz Albe <[email protected]>
Cc: David G. Johnston <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: jian he <[email protected]>
Subject: Re: doc: create table improvements
Date: Tue, 16 Dec 2025 10:14:00 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAKFQuwYfMV-2SdrP-umr5SVNSqTn378BUvHsebetp5=DhT494w@mail.gmail.com>
	<[email protected]>
	<CAKFQuwYk7NsEAEsPEUdbc_gXB0OR+gZzmBjDcUSe5JZuE+d_iw@mail.gmail.com>
	<[email protected]>
	<CACJufxFgZtLENzJkZZssKdWEfHo1hk9uyC0h3JcGJJb19XRJQQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAKFQuwaEo8dxUmVsmjkb4WBEtKHUazeaN1pwsbDpLsFdANDAkQ@mail.gmail.com>
	<[email protected]>



> On Oct 23, 2025, at 12:43, Laurenz Albe <[email protected]> wrote:
> 
> On Mon, 2025-10-20 at 07:41 -0400, David G. Johnston wrote:
>> I question whether “parameter” is even the correct class to assign here
>> and so would rather avoid the issue by not assigning a class.
> 
> Right.  I have removed the vestiges from my failed attempt to improve
> the "parameter" decorations.
> 
>> “If none is specified, the data will be persistent” would be better
>> written “If unspecified the data will be persistent” (or, “if not specified…”)
> 
> I decided to use the trusted phrasing "by default".
> 
>> Everything else looks good.
> 
> Patch attached; if it is fine with you, I'll mark it "ready for committer".
> 
> Yours,
> Laurenz Albe
> <v4-0001-Unclutter-CREATE-TABLE-synopsis.patch>

Overall the change looks good to me. I have only one comment about the naming of “oversize_storage”. Why not just “storage_parameters” or similar that sounds more straightforward?

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/









view thread (15+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: doc: create table improvements
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox