public inbox for [email protected]
help / color / mirror / Atom feedFrom: Daniel Gustafsson <[email protected]>
To: Haozhou Wang <[email protected]>
Cc: David Steele <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Hubert Zhang <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Subject: Re: Control your disk usage in PG: Introduction to Disk Quota Extension
Date: Fri, 31 Jul 2020 21:35:18 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAB0yre=mpb+8Ti9SokrXUZ7Hv2Hi1qDmQsP=d=dCmbh7buZ82w@mail.gmail.com>
<[email protected]>
<CAL_NLp+6W68ynPg1xYu_HZgQgWb2m+WueB7FPEzUhLc=v+=3kw@mail.gmail.com>
<[email protected]>
<CAL_NLpJLDJ6t0Uw=SVho=BT8MS=neCPAxvO+FYXNj_u2R11b2g@mail.gmail.com>
<[email protected]>
<CAL_NLpKWCE4tf93aS2DBe2Bs0Znst2TetVr9Jdj7FBGNqRaFyg@mail.gmail.com>
<[email protected]>
> On 1 Jul 2020, at 10:36, Daniel Gustafsson <[email protected]> wrote:
>
>> On 27 Mar 2020, at 11:22, Haozhou Wang <[email protected]> wrote:
>
>> We rebased this patch with the newest master.
>
> This patch now fails to build according to Travis:
>
> smgr.c: In function ‘smgrtruncate’:
> smgr.c:578:47: error: passing argument 4 of ‘smgrtruncate_hook’ makes integer from pointer without a cast [-Werror=int-conversion]
> (*smgrtruncate_hook)(reln, forknum, nforks, nblocks);
> ^
> smgr.c:578:47: note: expected ‘BlockNumber {aka unsigned int}’ but argument is of type ‘BlockNumber * {aka unsigned int *}’
>
>
> The warning is also present in the Windows build:
>
> src/backend/storage/smgr/smgr.c(578): warning C4047: 'function' : 'BlockNumber' differs in levels of indirection from 'BlockNumber *' [C:\projects\postgresql\postgres.vcxproj]
> src/backend/storage/smgr/smgr.c(578): warning C4024: 'smgrtruncate_hook' : different types for formal and actual parameter 4 [C:\projects\postgresql\postgres.vcxproj]
> 2 Warning(s)
>
> Marking the patch as Waiting for Author.
As the thread has stalled and the above compilation issue hasn't been
addressed, I'm marking this entry Returned with Feedback. Feel free to open a
new entry when there is a fixed patch.
cheers ./daniel
view thread (24+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Control your disk usage in PG: Introduction to Disk Quota Extension
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox