public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Justin Pryzby <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Devrim Gündüz <[email protected]>
Cc: [email protected]
Cc: Michael Paquier <[email protected]>
Subject: Re: head fails to build on SLES 12 (wal_compression=zstd)
Date: Thu, 31 Mar 2022 11:44:40 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Justin Pryzby <[email protected]> writes:
> Possible responses look like:
>  - Use 0 which also means "default" (need to verify that works across versions);
>  - Or #ifndef ZSTD_CLEVEL_DEFAULT #define ZSTD_CLEVEL_DEFAULT 3;
>  - Add a test for a minimum zstd version v1.3.7.  This may be a good idea for
>    v15 in any case, since we're using a few different APIs (at least
>    ZSTD_compress and ZSTD_compressStream2 and execve(zstd)).

In view of 51c0d186d ("Allow parallel zstd compression"), I agree
that some clarity about the minimum supported version of zstd
seems essential.  I don't want to be dealing with threading bugs
in ancient zstd versions.  However, why do you suggest 1.3.7 in
particular?

			regards, tom lane

view thread (14+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: head fails to build on SLES 12 (wal_compression=zstd)
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox