From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Solaris versus our NLS files
Date: Wed, 10 Dec 2025 11:49:02 -0500
Message-ID: <641931.1765385342@sss.pgh.pa.us> (raw)
In-Reply-To: <87o6o65pok.fsf@wibble.ilmari.org>
References: <202512101432.rkz3zbykficx@alvherre.pgsql>
<87o6o65pok.fsf@wibble.ilmari.org>
=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org> writes:
> Álvaro Herrera <alvherre@kurilemu.de> writes:
>> Oh. Well, that's clearly a process failure, and the fix will require us
>> deleting that file on all branches from 16 and up anyway, so I have no
>> issues with the plan of requiring all message catalogs to be UTF-8.
> Digging a bit more in the history of **/nb.po, there seems to be a
> policy that files that are less than 80% translated are removed¹, and I
> guess this file was just below the threshold on the 12-15 branches, but
> just above the threshold on master and 16+.
There may actually be an update-process bug here, because according to
[1], pg_config's nb translation is below 70% in all current branches.
So src/bin/pg_config/po/nb.po should not be propagated to gitmaster
in any branch later than v12, yet here it is in the more recent
branches. I'm suspecting a logic bug that fails to delete files
that should be deleted.
regards, tom lane
[1] https://babel.postgresql.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, ilmari@ilmari.org, alvherre@kurilemu.de, thomas.munro@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Solaris versus our NLS files
In-Reply-To: <641931.1765385342@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox