public inbox for [email protected]  

help / color / mirror / Atom feed

From: David Geier <[email protected]>
To: Tom Lane <[email protected]>
To: Robert Haas <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: get rid of Pointer type, mostly
Date: Mon, 24 Nov 2025 19:46:27 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<CA+Tgmobo9ZMC0h1Z1Te9whf7q3LN7wUkzFLyuxfMZ4dyTNqKnw@mail.gmail.com>
	<[email protected]>
	<CA+TgmobhKe5WJybZ0EGQ85Qkxr-KLx4uW2_hFqt0iPbYq-af7Q@mail.gmail.com>
	<[email protected]>

I'm in big favor of this change. Such types just cover up what's really
going on and make reading the code more difficult than needed,
especially for people new to the code base.

On 24.11.2025 19:26, Tom Lane wrote:
> Robert Haas <[email protected]> writes:

> I can follow the argument that using the native type "void *" is
> better, since every C programmer must know that already.  But you
> cannot argue for this patch on that ground unless Pointer goes away
> entirely.  I don't understand leaving it in place for GIN.  It's
> not like GIN indexes are some hoary backwater that nobody pays
> attention to.

+1

The GIN code makes use of pointer but src/backend/access/gin only has 29
occurrences. If you like I can help out fixing up the GIN code and share
a page here. Let me know.

--
David Geier

view thread (23+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: get rid of Pointer type, mostly
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox