From: Jacob Champion <pchampion@vmware.com>
To: tgl@sss.pgh.pa.us <tgl@sss.pgh.pa.us>
To: alvherre@alvh.no-ip.org <alvherre@alvh.no-ip.org>
Cc: daniel@yesql.se <daniel@yesql.se>
Cc: info@cspug.cz <info@cspug.cz>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: michael@paquier.xyz <michael@paquier.xyz>
Subject: Re: Preventing abort() and exit() calls in libpq
Date: Fri, 2 Jul 2021 22:15:45 +0000
Message-ID: <647ee70e51621c8f35c8c06d20faf8c96345e6d0.camel@vmware.com> (raw)
In-Reply-To: <604518.1625064175@sss.pgh.pa.us>
References: <202106301439.dji3ms64lxlj@alvherre.pgsql>
<604518.1625064175@sss.pgh.pa.us>
On Wed, 2021-06-30 at 10:42 -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > On 2021-Jun-30, Tom Lane wrote:
> > > You mentioned __gcov_exit, but I'm not sure if we need an
> > > exception for that. I see it referenced by the individual .o
> > > files, but the completed .so has no such reference, so at least
> > > on RHEL8 it's apparently satisfied during .so linkage. Do you
> > > see something different?
> > Well, not really. I saw it but only after I removed -fprofile-arcs from
> > Makefile.shlib's link line; but per my other email, that doesn't really
> > work.
> > Everything seems to work well for me after removing abort from that grep.
>
> OK, thanks, will push a fix momentarily.
With latest HEAD, building with --enable-coverage still fails on my
Ubuntu 20.04:
! nm -A -u libpq.so.5.15 2>/dev/null | grep -v __cxa_atexit | grep exit
libpq.so.5.15: U exit@@GLIBC_2.2.5
I don't see any exit references in the libpq objects or in
libpgport_shlib, so it seems like libpgcommon_shlib is the culprit... I
assume turning off optimizations leads to less dead code elimination?
--Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pchampion@vmware.com, tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, daniel@yesql.se, info@cspug.cz, michael@paquier.xyz
Subject: Re: Preventing abort() and exit() calls in libpq
In-Reply-To: <647ee70e51621c8f35c8c06d20faf8c96345e6d0.camel@vmware.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox