From: Andres Freund <andres@anarazel.de>
To: pgsql-hackers@lists.postgresql.org
Subject: Re: PATCH: Batch/pipelining support for libpq
Date: Wed, 18 Nov 2020 15:17:36 -0800
Message-ID: <6528520e-e5b1-4814-9877-aa6852aaa5f8@www.fastmail.com> (raw)
In-Reply-To: <20201118175134.GA30739@alvherre.pgsql>
References: <20201118175134.GA30739@alvherre.pgsql>
Hi
On Wed, Nov 18, 2020, at 09:51, Alvaro Herrera wrote:
> On 2020-Nov-14, Daniel Verite wrote:
>
> > The patch I posted in [1] was pretty simple, but at the time, query
> > results were always discarded. Now that pgbench can instantiate
> > variables from query results, a script can do:
> > select 1 as var \gset
> > select :var;
> > This kind of sequence wouldn't work in batch mode since it
> > sends queries before getting results of previous queries.
> >
> > So maybe \gset should be rejected when inside a batch section.
>
> Hah.
>
> Hacking pgbench extensively is beyond what I'm willing to do for this
> feature at this time. Making \gset rejected in a batch section sounds
> simple enough and supports \beginbatch et al sufficiently to compare
> performance, so I'm OK with a patch that does that. That'd be a small
> extension to your previous patch, if I understand correctly.
>
> If you or others want to send patches to extend batch support with
> read-write tracking for variables, feel free, but I hereby declare that
> I'm not taking immediate responsibility for getting them committed.
I think minimal support is entirely sufficient initially.
Andres
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andres@anarazel.de, pgsql-hackers@lists.postgresql.org
Subject: Re: PATCH: Batch/pipelining support for libpq
In-Reply-To: <6528520e-e5b1-4814-9877-aa6852aaa5f8@www.fastmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox