From: Bernd Helmle <mailings@oopsware.de>
To: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Banck <michael.banck@credativ.de>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Subject: Re: Offline enabling/disabling of data checksums
Date: Tue, 08 Jan 2019 15:39:30 +0100
Message-ID: <65e4f3684f7563acc8b309393b8e14388b5eae0d.camel@oopsware.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1901081505010.32421@lancre>
References: <20181221201616.GD4974@nighthawk.caipicrew.dd-dns.de>
<alpine.DEB.2.21.1812261900400.32444@lancre>
<20181227011534.GD2106@paquier.xyz>
<CABUevEwbPVR_6Uv4D44fCd9tB_=aFxG4awUx+DJawD8_speuCA@mail.gmail.com>
<alpine.DEB.2.21.1812271206340.32444@lancre>
<1546945543.32387.8.camel@credativ.de>
<alpine.DEB.2.21.1901081505010.32421@lancre>
Am Dienstag, den 08.01.2019, 15:09 +0100 schrieb Fabien COELHO:
> > The question is how to reliably do this in an acceptable way? Just
> > faking a postmaster.pid sounds pretty hackish to me, do you have
> > any
> > suggestions here?
>
> Adding a new state to ControlFileData which would prevent it from
> starting?
But then you have to make sure the control flag gets cleared in any
case pg_verify_checksums crashes somehow or gets SIGKILL'ed ...
Setting the checksum flag is done after having finished all blocks, so
there is no problem. But we need to set this new flag before and reset
it afterwards, so in between strange things can happen (as the various
calls to exit() within error handling illustrates).
Bernd.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: mailings@oopsware.de, coelho@cri.ensmp.fr, michael.banck@credativ.de, magnus@hagander.net, michael@paquier.xyz
Subject: Re: Offline enabling/disabling of data checksums
In-Reply-To: <65e4f3684f7563acc8b309393b8e14388b5eae0d.camel@oopsware.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox