pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Noah Misch <noah@leadboat.com>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: PoC/WIP: Extended statistics on expressions
Date: Sun, 06 Jun 2021 15:17:36 -0400
Message-ID: <660936.1623007056@sss.pgh.pa.us> (raw)
In-Reply-To: <4c98203c-8364-bb76-b502-d7b323ba55ba@enterprisedb.com>
References: <CAEZATCWYCY=2yEyxa6BwimCPQ_RZHy5GOb6U6i6dGHGQdjQESQ@mail.gmail.com>
	<e4556e47-940d-58a6-73fd-16c5815dd2cd@enterprisedb.com>
	<CAEZATCW2WHfsrbDLzwMvD+kOsBemLhvKwoHGhzR7STtac74XTg@mail.gmail.com>
	<a7d17aec-234d-c7f2-bfdc-99c87767a507@enterprisedb.com>
	<1ed534fb-b42b-f008-35ee-4eb930b0088f@enterprisedb.com>
	<CAEZATCV-JgFzb6aCJxApXg302u4vw+ajj702RHaBVkS_4JPVRg@mail.gmail.com>
	<2cb8a7cd-664f-8681-6ce9-790a50e3c78f@enterprisedb.com>
	<CAEZATCXsfFcXW_A1XCd5QK6zT2M_V+P3aPSktjibHHPzoV+Y-A@mail.gmail.com>
	<096d26e1-f053-a039-047d-a050dbb80ac6@enterprisedb.com>
	<078de413-8e4e-343e-fac1-eb61fd389925@enterprisedb.com>
	<20210606053740.GB297923@rfd.leadboat.com>
	<4c98203c-8364-bb76-b502-d7b323ba55ba@enterprisedb.com>

Tomas Vondra <tomas.vondra@enterprisedb.com> writes:
> On 6/6/21 7:37 AM, Noah Misch wrote:
>> This added a "transformed" field to CreateStatsStmt, but it didn't mention
>> that field in src/backend/nodes.  Should those functions handle the field?

> Yup, that's a mistake - it should do whatever CREATE INDEX is doing. Not
> sure if it can result in error/failure or just inefficiency (due to
> transforming the expressions repeatedly), but it should do whatever
> CREATE INDEX is doing.

I'm curious about how come the buildfarm didn't notice this.  The
animals using COPY_PARSE_PLAN_TREES should have failed.  The fact
that they didn't implies that there's no test case that makes use
of a nonzero value for this field, which seems like a testing gap.

			regards, tom lane





view thread (107+ messages)  latest in thread

Message-ID: <660936.1623007056@sss.pgh.pa.us>
Permalink:  ../660936.1623007056@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/660936.1623007056@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, tomas.vondra@enterprisedb.com, noah@leadboat.com, dean.a.rasheed@gmail.com, pryzby@telsasoft.com
  Subject: Re: PoC/WIP: Extended statistics on expressions
  In-Reply-To: <660936.1623007056@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox