pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: PSA: we lack TAP test coverage on NetBSD and OpenBSD
Date: Tue, 22 Jan 2019 10:46:29 -0500
Message-ID: <6661.1548171989@sss.pgh.pa.us> (raw)
In-Reply-To: <alpine.DEB.2.21.1901221054310.15365@lancre>
References: <9427.1547701450@sss.pgh.pa.us>
	<alpine.DEB.2.21.1901170659210.7416@lancre>
	<21538.1547770868@sss.pgh.pa.us>
	<4615.1547792324@sss.pgh.pa.us>
	<alpine.DEB.2.21.1901180926580.26418@lancre>
	<29225.1547834182@sss.pgh.pa.us>
	<alpine.DEB.2.21.1901182257480.20734@lancre>
	<alpine.DEB.2.21.1901201051270.14950@lancre>
	<7879.1548015981@sss.pgh.pa.us>
	<alpine.DEB.2.21.1901202225310.28945@lancre>
	<alpine.DEB.2.21.1901221054310.15365@lancre>

Fabien COELHO <coelho@cri.ensmp.fr> writes:
> Given these results, I do not think that it is useful to change 
> random_zipfian TAP test parameter from 2.5 to something else.

I'm not following this argument.  The test case is basically useless
for its intended purpose with that parameter, because it's highly
likely that the failure mode it's supposedly checking for will be
masked by the "random" function's tendency to spit out the same
value all the time.  We might as well drop zipfian from the test
altogether and save ourselves some buildfarm cycles.

			regards, tom lane




view thread (37+ messages)  latest in thread

Message-ID: <6661.1548171989@sss.pgh.pa.us>
Permalink:  ../6661.1548171989@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/6661.1548171989@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, coelho@cri.ensmp.fr, pgsql-hackers@lists.postgresql.org
  Subject: Re: PSA: we lack TAP test coverage on NetBSD and OpenBSD
  In-Reply-To: <6661.1548171989@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox