From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Julien Rouhaud <julien.rouhaud@dalibo.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: segfault in HEAD when too many nested functions call
Date: Tue, 18 Jul 2017 16:53:43 -0400
Message-ID: <6687.1500411223@sss.pgh.pa.us> (raw)
In-Reply-To: <20170717145710.cm32m4yn555hsoxd@alap3.anarazel.de>
References: <b0af9eaa-130c-60d0-9e4e-7a135b1e0c76@dalibo.com>
<12302.1500132157@sss.pgh.pa.us>
<20170717072629.dqykbsot2irdob7c@alap3.anarazel.de>
<20170717145710.cm32m4yn555hsoxd@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Andres Freund <andres@anarazel.de> writes:
> ... If we were to go this route we'd have to probably move
> the callback assignment into the ExecInit* routines, and possibly
> replace the switch in ExecInitNode() with another callback, assigned in
> make_*, and implement callbacks for ExecShutdown, MultiExecProcNode etc.
BTW, I don't see why you really need to mess with anything except
ExecProcNode? Surely the other cases such as MultiExecProcNode are
not called often enough to justify changing them away from the
switch technology. Yeah, maybe it would be a bit cleaner if they
all looked alike ... but if you're trying to make a patch that's
as little invasive as possible for v10, I'd suggest converting just
ExecProcNode to this style.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, julien.rouhaud@dalibo.com
Subject: Re: segfault in HEAD when too many nested functions call
In-Reply-To: <6687.1500411223@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox