From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Tatsuo Ishii <ishii@postgresql.org>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Fix for Extra Parenthesis in pgbench progress message
Date: Wed, 27 Nov 2024 23:13:41 +0900
Message-ID: <67111cd9-a7fa-4424-a1ed-faf06aa40047@oss.nttdata.com> (raw)
In-Reply-To: <20241127.184140.897862112615216224.ishii@postgresql.org>
References: <95f1100e-e59b-41b7-a406-f865c2e69db7@oss.nttdata.com>
<20241125.083155.1820744655877715597.ishii@postgresql.org>
<ffc99be5-e418-40ee-91d6-62c3deb42918@oss.nttdata.com>
<20241127.184140.897862112615216224.ishii@postgresql.org>
On 2024/11/27 18:41, Tatsuo Ishii wrote:
>> Yes, I will.
>>
>> But, the patch didn't apply cleanly to some back branches, so I've
>> created
>> and attached updated patches for them. Could you review these?
>> If they look good, I'll proceed with pushing them.
>
> Sure. The patch for master to v15 look good to me. Unfortunately
> v5-0001-pgbench-Ensure-previous-progress-message-is-fully-pg13-14.patch
> applies to v14 but does not apply to v13.
>
> $ git checkout REL_13_STABLE
> Switched to branch 'REL_13_STABLE'
> Your branch is up to date with 'origin/REL_13_STABLE'.
> $ git apply ~/v5-0001-pgbench-Ensure-previous-progress-message-is-fully-pg13-14.patch
> error: patch failed: src/bin/pgbench/pgbench.c:4222
> error: src/bin/pgbench/pgbench.c: patch does not apply
>
> So I created a patch for pg13 using patch command. Attached is the
> patch for pg13.
I was applying the patch to v13 by first applying it to v14 and then using
git cherry-pick for v13, which worked fine. Anyway, thank you for providing
the patch for v13! I've now pushed the patches.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: masao.fujii@oss.nttdata.com, ishii@postgresql.org
Subject: Re: Fix for Extra Parenthesis in pgbench progress message
In-Reply-To: <67111cd9-a7fa-4424-a1ed-faf06aa40047@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox