From: Michael Banck <mbanck@gmx.net>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Safeguards against incorrect fd flags for fsync()
Date: Tue, 10 Jun 2025 23:09:31 +0200
Message-ID: <68489f0b.050a0220.21ce72.f4b3@mx.google.com> (raw)
In-Reply-To: <68480868.5d0a0220.1e214d.68a6@mx.google.com>
References: <20191009062640.GB21379@paquier.xyz>
<68480868.5d0a0220.1e214d.68a6@mx.google.com>
Hi,
one more thing:
On Tue, Jun 10, 2025 at 12:26:48PM +0200, Michael Banck wrote:
> The better way might be to mask the flags with O_ACCMODE and then just
> check what you want, like in the attached.
I forgot to mention it in the patch, but Samuel Thibault reviewed the
patch and suggested improvements to the point where he should probably
be credited as co-author but at least as reviewer should this be
accepted.
Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: mbanck@gmx.net, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
Subject: Re: Safeguards against incorrect fd flags for fsync()
In-Reply-To: <68489f0b.050a0220.21ce72.f4b3@mx.google.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox