public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andreas Karlsson <[email protected]>
To: Peter Eisentraut <[email protected]>
To: pgsql-hackers <[email protected]>
Subject: Re: Put genbki.pl output into src/include/catalog/ directly
Date: Thu, 14 Mar 2024 02:33:35 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

On 3/13/24 12:41 PM, Andreas Karlsson wrote:
> On 2/8/24 8:58 AM, Peter Eisentraut wrote:
>> I think keeping the two build systems aligned this way will be useful 
>> for longer-term maintenance.
> 
> Agreed, so started reviewing the patch. Attached is a rebased version of 
> the patch to solve a conflict.

I have reviewed the patch now and would say it looks good. I like how we 
remove the symlinks plus make things more similar to the meson build so 
I think we should merge this.

I tried building, running tests, running make clean, running make 
install and tried building with meson (plus checking that meson really 
checks for the generated files and actually refuse to build). Everything 
worked as expected.

The code changes look clean and mostly consist of moving code. I 
personally think this is ready for committer.

Andreas

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Put genbki.pl output into src/include/catalog/ directly
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox