pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Noah Misch <noah@leadboat.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: SQL-standard function body
Date: Mon, 10 May 2021 11:09:43 -0400
Message-ID: <688709.1620659383@sss.pgh.pa.us> (raw)
In-Reply-To: <cfe5eac0-64ea-01d0-8ebc-94a16869490f@enterprisedb.com>
References: <1c11f1eb-f00c-43b7-799d-2d44132c02d7@2ndquadrant.com>
	<CA+TgmoZ-FXU0iyevFETN0sGYw0RKTSCFxKONGE+2nVJEM5_8OQ@mail.gmail.com>
	<493812.1593541480@sss.pgh.pa.us>
	<494838.1593543098@sss.pgh.pa.us>
	<20210418185546.GC1500781@rfd.leadboat.com>
	<92408.1618772924@sss.pgh.pa.us>
	<20210418211505.GA7256@telsasoft.com>
	<142618.1618781618@sss.pgh.pa.us>
	<964466e9-6b6c-c0ae-6277-a44e80229299@enterprisedb.com>
	<2659727.1619540213@sss.pgh.pa.us>
	<cfe5eac0-64ea-01d0-8ebc-94a16869490f@enterprisedb.com>

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> On 27.04.21 18:16, Tom Lane wrote:
>> That's kind of a lot of complication, and inefficiency, for a corner case
>> that may never arise in practice.  We've ignored the risk for default
>> expressions, and AFAIR have yet to receive any field complaints about it.
>> So maybe it's okay to do the same for SQL-style function bodies, at least
>> for now.

>>> Another option would be that we disallow this at creation time.

>> Don't like that one much.  The backend shouldn't be in the business
>> of rejecting valid commands just because pg_dump might be unable
>> to cope later.

> Since this is listed as an open item, I want to clarify that I'm 
> currently not planning to work on this, based on this discussion. 
> Certainly something to look into sometime later, but it's not in my 
> plans right now.

Right, I concur with moving it to the "won't fix" category.

			regards, tom lane





view thread (90+ messages)  latest in thread

Message-ID: <688709.1620659383@sss.pgh.pa.us>
Permalink:  ../688709.1620659383@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/688709.1620659383@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, pryzby@telsasoft.com, noah@leadboat.com, robertmhaas@gmail.com
  Subject: Re: SQL-standard function body
  In-Reply-To: <688709.1620659383@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox