From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: logical decoding / rewrite map vs. maxAllocatedDescs
Date: Sat, 11 Aug 2018 10:15:56 -0400
Message-ID: <6899.1533996956@sss.pgh.pa.us> (raw)
In-Reply-To: <79a0c7f4-89fb-cf8d-82eb-5a7ca8e08d56@2ndquadrant.com>
References: <20180809174746.aa6rbpsu4zjipzif@alvherre.pgsql>
<b346c3eb-0e65-29ec-47db-0d9a46feaa2c@2ndquadrant.com>
<20180810211340.nlgyfa7jlmkjcs5m@alap3.anarazel.de>
<79a0c7f4-89fb-cf8d-82eb-5a7ca8e08d56@2ndquadrant.com>
Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
>>> On 08/09/2018 07:47 PM, Alvaro Herrera wrote:
>>>> Actually, it seems to me that ApplyLogicalMappingFile is just leaking
>>>> the file descriptor for no good reason.
> I think the fix can be as simple as attached ... I'm mostly afk for the
> weekend, so I'll commit & backpatch on Monday or so.
LGTM. While you're at it, would you fix the misspelling three lines
below this?
* Check whether the TransactionOId 'xid' is in the pre-sorted array 'xip'.
^
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, tomas.vondra@2ndquadrant.com, andres@anarazel.de, alvherre@2ndquadrant.com
Subject: Re: logical decoding / rewrite map vs. maxAllocatedDescs
In-Reply-To: <6899.1533996956@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox