public inbox for [email protected]  

help / color / mirror / Atom feed
From: David E. Wheeler <[email protected]>
To: Robert Haas <[email protected]>
Cc: Florents Tselai <[email protected]>
Cc: Alexander Korotkov <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part
Date: Wed, 21 May 2025 14:13:28 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+Tgmoa-9tN85bEHfH7TBHa5uV1TwmZJEh_eYkLnwxOV=i6RSg@mail.gmail.com>
References: <CA+v5N40sJF39m0v7h=QN86zGp0CUf9F1WKasnZy9nNVj_VhCZQ@mail.gmail.com>
	<[email protected]>
	<CAPpHfdtGhn_5jfLoepOScyqT+FXYB9QtV-OEprychDcMJco7mw@mail.gmail.com>
	<CA+v5N42PVJH3HbwLE1yC75XR6E5zGnCCdtSUXfgFwtGyPP8XYg@mail.gmail.com>
	<CA+Tgmob03B6h1SMsi7vs9uOX+vrqg_tyhh--mKC3BaTJ08qKYA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CA+Tgmoa-9tN85bEHfH7TBHa5uV1TwmZJEh_eYkLnwxOV=i6RSg@mail.gmail.com>

On May 21, 2025, at 14:06, Robert Haas <[email protected]> wrote:

> No, that wouldn't be too much work, but the issue is that people will
> keep using the _tz versions and when we eventually try to remove them
> those people will complain no matter how prominent we make the
> deprecation notice. If we want to go this route, maybe we should do
> something like:
> 
> 1. Add the new versions with a _s suffix or whatever.
> 
> 2. Invent a GUC jsonb_tz_warning = { on | off } that advises you to
> use the new functions instead, whenever you use the old ones.
> 
> 3. After N years, flip the default value from off to on.
> 
> 4. After M additional years, remove the old functions and the GUC.
> 
> 5. Still get complaints.

Complainers gonna complain. 🫠

Any idea how widespread the use of the function is? It was added in 17, and I’ve met few who have really dug into the jonpath stuff yet, let alone needed the time zone conversion functionality.

Best,

David



Attachments:

  [application/pgp-signature] signature.asc (833B, 2-signature.asc)
  download

view thread (56+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox