public inbox for [email protected]  

help / color / mirror / Atom feed

From: Chao Li <[email protected]>
To: Baji Shaik <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Two small errhint cleanups in PG19 code
Date: Mon, 25 May 2026 13:38:26 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+fm-RMrKbyky_+vi5SDdAVnFVjWh7zW3GoDAVnrp5OpDnW6tw@mail.gmail.com>
References: <CA+fm-RMrKbyky_+vi5SDdAVnFVjWh7zW3GoDAVnrp5OpDnW6tw@mail.gmail.com>



> On May 25, 2026, at 10:38, Baji Shaik <[email protected]> wrote:
> 
> Hi,
> 
> While exploring new features in PG19, I came across two unrelated
> small errhint issues. Sending them as separate patches in one thread since they touch
> unrelated subsystems and can be reviewed/committed independently.
> 
> Patch 0001 -- Remove stray word in pg_restore_extended_stats() errhint
> The errhint in import_pg_statistic() reads:
> 
>       Value of element "%s" must be type a null or a string.
> 
>   The word "type" is a stray word that doesn't belong; the intent is
>   "must be a null or a string".

Agreed.

> 
> Patch 0002 -- Add missing period to online data checksums errhint
>   The errhint emitted when StartupXLOG() detects an interrupted
>   "enabling data checksums" run is missing a trailing period:
> 
>       Data checksum processing must be manually restarted for
>       checksums to be enabled
> 

Yes, a hint message should end with a period.

> Thanks,
> Baji Shaik
> <0002-Add-missing-period-to-online-data-checksums-errhint.patch><0001-Remove-stray-word-in-pg_restore_extended_stats-errhi.patch>


So, both changes look good to me.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Two small errhint cleanups in PG19 code
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox