pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Bossart, Nathan <bossartn@amazon.com>
To: Thomas Munro <thomas.munro@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: race condition when writing pg_control
Date: Mon, 8 Jun 2020 03:25:31 +0000
Message-ID: <6D187DAC-C177-4556-929D-718094FF6143@amazon.com> (raw)
In-Reply-To: <CA+hUKGKToqjdeRtr8ZHVbPToShun5ifjioj6x3nsjseOkhCMEQ@mail.gmail.com>
References: <CA+hUKGLO3jStOdDgq72u=P6rDjLfwZT3Fawzd1PyLb9R2+Peow@mail.gmail.com>
	<CA+hUKGJ+rud16GvO1Gg9V0P26tz7Rvz3cYVfW144b8=8ENtJ0g@mail.gmail.com>
	<637e17dd-e90b-0dab-f215-dbbe9c6c726a@oss.nttdata.com>
	<20200523053935.GB266978@paquier.xyz>
	<D162D812-D724-4B79-8D6C-CB1EFC9A796E@amazon.com>
	<20200527071053.GD103662@paquier.xyz>
	<fc796148-7d63-47bb-e91d-e09b62a502e9@oss.nttdata.com>
	<A9F111A3-560A-4C21-A35B-9D3182704187@amazon.com>
	<20200602052427.GC3594@paquier.xyz>
	<CA+hUKGJJJOP1jfw4yRqozXghiqtXRH0gisHyNwa+nzCL_xyjcg@mail.gmail.com>
	<20200603020259.GA89559@paquier.xyz>
	<CA+hUKGKToqjdeRtr8ZHVbPToShun5ifjioj6x3nsjseOkhCMEQ@mail.gmail.com>

On 6/7/20, 7:50 PM, "Thomas Munro" <thomas.munro@gmail.com> wrote:
> I pushed 0001 and 0002, squashed into one commit.  I'm not sure about
> 0003.  If we're going to do that, wouldn't it be better to just
> acquire the lock in that one extra place in StartupXLOG(), rather than
> introducing the extra parameter?

Thanks!  The approach for 0003 was discussed a bit upthread [0].  I do
not have a strong opinion, but I lean towards just acquiring the lock.

Nathan

[0] https://postgr.es/m/20200527071053.GD103662%40paquier.xyz



view thread (32+ messages)  latest in thread

Message-ID: <6D187DAC-C177-4556-929D-718094FF6143@amazon.com>
Permalink:  ../6D187DAC-C177-4556-929D-718094FF6143@amazon.com/
Also on:    postgresql.org/message-id/6D187DAC-C177-4556-929D-718094FF6143@amazon.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: bossartn@amazon.com, thomas.munro@gmail.com, michael@paquier.xyz, masao.fujii@oss.nttdata.com
  Subject: Re: race condition when writing pg_control
  In-Reply-To: <6D187DAC-C177-4556-929D-718094FF6143@amazon.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox