public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Paul Jungwirth <[email protected]>
Cc: jian he <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: vignesh C <[email protected]>
Subject: Re: SQL:2011 application time
Date: Tue, 10 Dec 2024 15:40:40 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CA+renyUApHgSZF9-nd-a0+OPGharLQLO=mDHcY4_qQ0+noCUVg@mail.gmail.com>
	<CACJufxECGaLjMcN8TJbX1fGrMFKs6qu+6RiZm98=sLcpiVpu2g@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CA+renyUFC13F0tYKxEENZtWA0YVuS5Tv+ZQkEkAwuDO1-Xke-A@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On 07.12.24 20:29, Paul Jungwirth wrote:
> These five patches all look good to me.
> 
> Note that my tests already include a section for REPLICA IDENTITY FULL, 
> which passed. But the subscriber was using a SeqScan to look up tuples 
> to update.
> 
> Here are the steps (mostly just because it was confusing for me at 
> first): First in FindUsableIndexForReplicaIdentityFull, we would call 
> IsIndexUsableForReplicaIdentityFull, get back false, and decide there 
> was no index to use. Then in FindReplTupleInLocalRel, localidxoid was 0, 
> so we woudln't call IsIndexUsableForReplicaIdentityFull at all.
> 
> After applying the five patches, I can see that we choose the index and 
> call IsIndexUsableForReplicaIdentityFull from both sites. This should 
> make applying changes a lot faster.

I have committed these.  I will continue with reviewing v45-0002 and 
following now.

view thread (23+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: SQL:2011 application time
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox