pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Greg Nancarrow <gregn4422@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: houzj.fnst@fujitsu.com <houzj.fnst@fujitsu.com>
Cc: vignesh C <vignesh21@gmail.com>
Cc: tanghy.fnst@fujitsu.com <tanghy.fnst@fujitsu.com>
Cc: osumi.takamichi@fujitsu.com <osumi.takamichi@fujitsu.com>
Cc: Alexey Lesovsky <lesovsky@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Skipping logical replication transactions on subscriber side
Date: Fri, 17 Dec 2021 10:53:48 +0100
Message-ID: <6c5d98c6-879d-690c-b769-96aa162b93d9@enterprisedb.com> (raw)
In-Reply-To: <CAJcOf-fBLiHZdUKpOQ=gN1BZrt4imMwAVUFGK=TyWyVfdf0VHg@mail.gmail.com>
References: <CAA4eK1KzZp5YC34exW3Yb4Vk9v5iMW0YuJCQsWeTOeF7ejLdXw@mail.gmail.com>
	<CAA4eK1K2yKC-Eve+tACyfAkniy4VvLqiGU-F9Vtg0yNO7MjZzw@mail.gmail.com>
	<CAD21AoBNPPEySdB8M7mG9KSg5+F9nfbo8LrWU7d=5uvQ18Uumw@mail.gmail.com>
	<CAA4eK1LasocmhFeBb0D4ixf_J=pDr1OYdyTnEvbhcYToqA=GMw@mail.gmail.com>
	<CAD21AoBnxmRGMv5CZHVosp+g-vUzZtcJ0ecxfvk+aLEqTKFa-g@mail.gmail.com>
	<CAA4eK1Lfn2VPEK2J=+JOZkmkdtTwVd2GyPwvr7=iVUaSMgNTXw@mail.gmail.com>
	<CAD21AoAGiUYhiNgyr4A9928gDmbU95ai9K0Od7c2MeP_dXuDbA@mail.gmail.com>
	<CAA4eK1LCfWf8JVnzdmk3PORZHgfC=DUuJh5dUD9PP5QeNknJMQ@mail.gmail.com>
	<CAD21AoCAL08VPW9GeVdr5E=mShs2PG65KhujJfP6Gntz==zknQ@mail.gmail.com>
	<CAA4eK1+ET_L03k_GW2ruOpLK5bfJLxaY+4sqo161FgoUyim4kw@mail.gmail.com>
	<CAD21AoCG+X+xdbW=ZUxaqGN4G+b6JJW4vKdxbu6oRxa6NY8XNw@mail.gmail.com>
	<CAA4eK1La0Oum41L9=bgdU6AjJXY7TvPXEWhgm+sKtdg3JCY27w@mail.gmail.com>
	<CAD21AoBRDU3dzUbw0zeQfKfJ79rWCbYKEaTLoJbHpP6VomiY_Q@mail.gmail.com>
	<CAJcOf-fBLiHZdUKpOQ=gN1BZrt4imMwAVUFGK=TyWyVfdf0VHg@mail.gmail.com>

On 13.12.21 04:12, Greg Nancarrow wrote:
> (ii) "Setting -1 means to reset the transaction ID"
> 
> Shouldn't it be explained what resetting actually does and when it can
> be, or is needed to be, done? Isn't it automatically reset?
> I notice that negative values (other than -1) seem to be regarded as
> valid - is that right?
> Also, what happens if this option is set multiple times? Does it just
> override and use the latest setting? (other option handling errors out
> with errorConflictingDefElem()).
> e.g. alter subscription sub skip (xid = 721, xid = 722);

Let's not use magic numbers and instead use a syntax that is more 
explicit, like SKIP (xid = NONE) or RESET SKIP or something like that.





view thread (590+ messages)  latest in thread

Message-ID: <6c5d98c6-879d-690c-b769-96aa162b93d9@enterprisedb.com>
Permalink:  ../6c5d98c6-879d-690c-b769-96aa162b93d9@enterprisedb.com/
Also on:    postgresql.org/message-id/6c5d98c6-879d-690c-b769-96aa162b93d9@enterprisedb.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, gregn4422@gmail.com, sawada.mshk@gmail.com, amit.kapila16@gmail.com, houzj.fnst@fujitsu.com, vignesh21@gmail.com, tanghy.fnst@fujitsu.com, osumi.takamichi@fujitsu.com, lesovsky@gmail.com
  Subject: Re: Skipping logical replication transactions on subscriber side
  In-Reply-To: <6c5d98c6-879d-690c-b769-96aa162b93d9@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox