pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Thomas Munro <thomas.munro@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Brown <michael.brown@discourse.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: fdatasync performance problem with large number of DB files
Date: Tue, 16 Mar 2021 17:10:28 +0900
Message-ID: <6d4a78fa-f18a-e40c-8e39-a069f9d9bca8@oss.nttdata.com> (raw)
In-Reply-To: <CA+hUKGK0hZ1jBCF6r+J9=CVwpAUTU7EB3_SUp5Owp0zym4eksg@mail.gmail.com>
References: <11bc2bb7-ecb5-3ad0-b39f-df632734cd81@discourse.org>
	<CA+hUKGLt7zoFcJemmXzL=ZB3Rdse6Ds_Mm05G5Ogai_yZRp2=A@mail.gmail.com>
	<CA+hUKGLgb4ZMV6xQrZb8N5ax0g+EZR=b0dtg9pPJmsBtaun1-A@mail.gmail.com>
	<2255953.1615421770@sss.pgh.pa.us>
	<CA+hUKGJ6bpG1ghgZccJ57fpyZRHNu2xJkWRmaEP4TEBuXutS-Q@mail.gmail.com>
	<2258680.1615425905@sss.pgh.pa.us>
	<CA+hUKGLkcJ=9qD69NU0W6SEz-JGzdDtjjF2TedoYKgD2ky=atg@mail.gmail.com>
	<CA+hUKGLABi5asn5yFXBrAC0d3dGBN8QHvLq=27sa7thCQV4Z1w@mail.gmail.com>
	<CA+hUKGK0hZ1jBCF6r+J9=CVwpAUTU7EB3_SUp5Owp0zym4eksg@mail.gmail.com>



On 2021/03/15 8:33, Thomas Munro wrote:
> On Mon, Mar 15, 2021 at 11:52 AM Thomas Munro <thomas.munro@gmail.com> wrote:
>> Time being of the essence, here is the patch I posted last year, this
>> time with a GUC and some docs.  You can set sync_after_crash to
>> "fsync" (default) or "syncfs" if you have it.
> 
> Cfbot told me to add HAVE_SYNCFS to Solution.pm, and I fixed a couple of typos.

Thanks for the patch!

+        When set to <literal>fsync</literal>, which is the default,
+        <productname>PostgreSQL</productname> will recursively open and fsync
+        all files in the data directory before crash recovery begins.

Isn't this a bit misleading? This may cause users to misunderstand that
such fsync can happen only in the case of crash recovery.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION





view thread (49+ messages)  latest in thread

Message-ID: <6d4a78fa-f18a-e40c-8e39-a069f9d9bca8@oss.nttdata.com>
Permalink:  ../6d4a78fa-f18a-e40c-8e39-a069f9d9bca8@oss.nttdata.com/
Also on:    postgresql.org/message-id/6d4a78fa-f18a-e40c-8e39-a069f9d9bca8@oss.nttdata.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, thomas.munro@gmail.com, tgl@sss.pgh.pa.us, michael.brown@discourse.org
  Subject: Re: fdatasync performance problem with large number of DB files
  In-Reply-To: <6d4a78fa-f18a-e40c-8e39-a069f9d9bca8@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox