public inbox for [email protected]  

help / color / mirror / Atom feed
From: Andrew Dunstan <[email protected]>
To: Noah Misch <[email protected]>
Cc: jian he <[email protected]>
Cc: Mahendra Singh Thalor <[email protected]>
Cc: tushar <[email protected]>
Cc: Vaibhav Dalvi <[email protected]>
Cc: [email protected]
Subject: Re: Non-text mode for pg_dumpall
Date: Thu, 18 Jun 2026 09:43:09 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CACJufxFs9NXXTeb78i2MD+pnZootayAtiGcNHNeU35SmQgMjbA@mail.gmail.com>
	<[email protected]>
	<CACJufxEnmJ8otfmN7Kp110Wqi=M4YE0-zn-W6SK+eTpWuZw_fg@mail.gmail.com>
	<CAKYtNAqxjQMLVPfz6XESqszhxZKgigi7UEBzBhz_Wj_Bnasdag@mail.gmail.com>
	<[email protected]>
	<CACJufxE-zJiBAaZABtJBJr8FZdj=xP5adf_excmu9S6Op=KpLA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>


On 2026-06-17 We 5:59 PM, Noah Misch wrote:
> On Mon, Jun 15, 2026 at 04:11:16PM -0400, Andrew Dunstan wrote:
>> On 2026-06-06 Sa 8:02 PM, Noah Misch wrote:
>>> On Thu, Feb 26, 2026 at 09:02:48AM -0500, Andrew Dunstan wrote:
>>>> pushed with a slight tweak.
>>> Having now reviewed commit 763aaa0, I don't think it's ready to remain part of
>>> v19.  While some points from my v18 review are now resolved, other points
>>> still seem unresolved.  I didn't find discussion of the unresolved points.  I
>>> also see new issues.
>> OK, here's a reversion path. It's a bit messy, and I didn't touch the
>> release notes, but apart from that I think it does the right thing.
> I checked "git diff 763aaa06f03^ src/bin/pg_dump/{*.c,*.h,t}" and I agree this
> reverts everything.  Thanks for working through the revert.


Thanks for checking. Pushed with the release notes update.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com


view thread (111+ messages)

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Non-text mode for pg_dumpall
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox