pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feed[OAuth] Missing dependency on oauth_validator test
3+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2026-01-27 c6a10a89fe 444826b6dc oauth: Correct test dependency on oauth_hook_client
* [OAuth] Missing dependency on oauth_validator test
@ 2026-01-17 17:20 Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Gonzalez V. @ 2026-01-17 17:20 UTC (permalink / raw)
To: pgsql-hackers@lists.postgresql.org
Hi,
While working in another patch[1] I found that the test for the
oauth_validator was failing when running the test using:
meson test -C build --setup --suite oauth_validator
This was due to the binary `oauth_hook_client` being missing because I
build the code without enabling the OAuth test using `PG_EXTRA_TEST`.
I'm attaching a small patch that add the binary dependency in the
meson.build file, thus, it will be build before running the test.
Regards,
[1] https://commitfest.postgresql.org/patch/6183/
--
Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
EnterpriseDB
Attachments:
v1-0001-Add-missing-dependency-oauth_hook_client-on-oauth.patch (text/x-patch, 994B) download
From 2f7ed1cdcad8e03ac865f916a8ad26ffe6dd7e53 Mon Sep 17 00:00:00 2001
From: "Jonathan Gonzalez V." <jonathan.abdiel@gmail.com>
Date: Sat, 17 Jan 2026 18:00:18 +0100
Subject: [PATCH v1 1/1] Add missing dependency oauth_hook_client on
oauth_validator test
The test was missing the oauth_hook_client as dependency, therefore,
the dependency wasn't being build when running just `meson test`
making the tests fail.
Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
---
src/test/modules/oauth_validator/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/test/modules/oauth_validator/meson.build b/src/test/modules/oauth_validator/meson.build
index 3e8854739a2..c4b73e05297 100644
--- a/src/test/modules/oauth_validator/meson.build
+++ b/src/test/modules/oauth_validator/meson.build
@@ -81,5 +81,6 @@ tests += {
'with_libcurl': oauth_flow_supported ? 'yes' : 'no',
'with_python': 'yes',
},
+ 'deps': [oauth_hook_client],
},
}
--
2.51.0
* Re: [OAuth] Missing dependency on oauth_validator test
@ 2026-01-27 20:17 Jacob Champion <jacob.champion@enterprisedb.com>
parent: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Jacob Champion @ 2026-01-27 20:17 UTC (permalink / raw)
To: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>; Andres Freund <andres@anarazel.de>; +Cc: pgsql-hackers@lists.postgresql.org
On Sat, Jan 17, 2026 at 9:31 AM Jonathan Gonzalez V.
<jonathan.abdiel@gmail.com> wrote:
> I'm attaching a small patch that add the binary dependency in the
> meson.build file, thus, it will be build before running the test.
Pushed and backpatched, thanks! I missed the conversation in [1],
where this was fixed for the other binaries.
Andres, do you know of any way we could surface these missing deps
with only the "standard" meson/ninja invocations? The only idea I had
was to not build the test executables by default, but I think that
trades a small problem (we occasionally hit a build-time dependency
bug) for a big one (devs fail to notice that a test executable doesn't
compile).
--Jacob
[1] https://postgr.es/m/qh4c5tvkgjef7jikjig56rclbcdrrotngnwpycukd2n3k25zi2%4044hxxvtwmgum
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [OAuth] Missing dependency on oauth_validator test
@ 2026-01-27 22:39 Andres Freund <andres@anarazel.de>
parent: Jacob Champion <jacob.champion@enterprisedb.com>
0 siblings, 0 replies; 3+ messages in thread
From: Andres Freund @ 2026-01-27 22:39 UTC (permalink / raw)
To: Jacob Champion <jacob.champion@enterprisedb.com>; +Cc: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>; pgsql-hackers@lists.postgresql.org
Hi,
On 2026-01-27 12:17:21 -0800, Jacob Champion wrote:
> Andres, do you know of any way we could surface these missing deps
> with only the "standard" meson/ninja invocations?
I don't see a realistic magic solution here, unfortunately.
> The only idea I had was to not build the test executables by default, but I
> think that trades a small problem (we occasionally hit a build-time
> dependency bug) for a big one (devs fail to notice that a test executable
> doesn't compile).
I was thinking that we ought to do that, just to make the compile-hack loop a
bit shorter. If we then run the tests in some CI tasks after cleaning the
build tree, it should find most of the omissions.
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-01-27 22:39 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-01-17 17:20 [OAuth] Missing dependency on oauth_validator test Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
2026-01-27 20:17 ` Jacob Champion <jacob.champion@enterprisedb.com>
2026-01-27 22:39 ` Andres Freund <andres@anarazel.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox