From: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Subject: [OAuth] Missing dependency on oauth_validator test
Date: Sat, 17 Jan 2026 18:20:55 +0100
Message-ID: <6e8f4f7c23faf77c4b6564c4b7dc5d3de64aa491.camel@gmail.com> (raw)
Hi,
While working in another patch[1] I found that the test for the
oauth_validator was failing when running the test using:
meson test -C build --setup --suite oauth_validator
This was due to the binary `oauth_hook_client` being missing because I
build the code without enabling the OAuth test using `PG_EXTRA_TEST`.
I'm attaching a small patch that add the binary dependency in the
meson.build file, thus, it will be build before running the test.
Regards,
[1] https://commitfest.postgresql.org/patch/6183/
--
Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
EnterpriseDB
Attachments:v1-0001-Add-missing-dependency-oauth_hook_client-on-oauth.patch (text/x-patch, 994B) download
From 2f7ed1cdcad8e03ac865f916a8ad26ffe6dd7e53 Mon Sep 17 00:00:00 2001
From: "Jonathan Gonzalez V." <jonathan.abdiel@gmail.com>
Date: Sat, 17 Jan 2026 18:00:18 +0100
Subject: [PATCH v1 1/1] Add missing dependency oauth_hook_client on
oauth_validator test
The test was missing the oauth_hook_client as dependency, therefore,
the dependency wasn't being build when running just `meson test`
making the tests fail.
Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
---
src/test/modules/oauth_validator/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/test/modules/oauth_validator/meson.build b/src/test/modules/oauth_validator/meson.buildindex 3e8854739a2..c4b73e05297 100644--- a/src/test/modules/oauth_validator/meson.build+++ b/src/test/modules/oauth_validator/meson.build@@ -81,5 +81,6 @@ tests += {
'with_libcurl': oauth_flow_supported ? 'yes' : 'no',
'with_python': 'yes',
},
+ 'deps': [oauth_hook_client],
},
}
--
2.51.0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: jonathan.abdiel@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: [OAuth] Missing dependency on oauth_validator test
In-Reply-To: <6e8f4f7c23faf77c4b6564c4b7dc5d3de64aa491.camel@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox