public inbox for [email protected]  
help / color / mirror / Atom feed
From: Peter Eisentraut <[email protected]>
To: Paul A Jungwirth <[email protected]>
To: Zsolt Parragi <[email protected]>
Cc: Sergei Patiakin <[email protected]>
Cc: [email protected]
Subject: Re: Inconsistent trigger behavior between two temporal leftovers
Date: Thu, 4 Jun 2026 11:18:24 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+renyWRW2XUoqXL7-WOEeTh2gW4dsTQMACR1fGNRFJTmsggBw@mail.gmail.com>
References: <CANE55rCqcse_pwXBMWhbj3_7XROb8Dks6=OLFmKy3bO3zDsCsg@mail.gmail.com>
	<CANE55rCYx3K1i6JUQjspK1t1G3OXWGOOuSqy0JA+P8Mi0o=tKg@mail.gmail.com>
	<CAN4CZFMECdY4eJzd207Z0jn5Hq_AtBHzCrvhFNteRYVN0Ru8tg@mail.gmail.com>
	<CA+renyWRW2XUoqXL7-WOEeTh2gW4dsTQMACR1fGNRFJTmsggBw@mail.gmail.com>

On 05.05.26 23:48, Paul A Jungwirth wrote:
> On Tue, May 5, 2026 at 2:16 PM Zsolt Parragi <[email protected]> wrote:
>>
>> + /*
>> + * Re-copy the original row into leftoverSlot because
>> + * ExecInsert may pass leftoverSlot to BEFORE INSERT
>> + * triggers, which can modify the slot contents.
>> + */
>>
>> Shouldn't this mention BEFORE ROW INSERT triggers? Everywhere else the
>> comments/commit message/test is specific about this.
> 
> I agree being specific is helpful. Here is an updated patch.

committed







reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Inconsistent trigger behavior between two temporal leftovers
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox