From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Reporting script runtimes in pg_regress
Date: Mon, 11 Feb 2019 09:44:24 +0100
Message-ID: <6f1657f9-c58c-ba28-0013-d36a6f6fd246@2ndquadrant.com> (raw)
In-Reply-To: <11413.1549835730@sss.pgh.pa.us>
References: <16646.1549770618@sss.pgh.pa.us>
<E7790843-B885-492B-8537-CC9FB39D5F97@yesql.se>
<11413.1549835730@sss.pgh.pa.us>
On 10/02/2019 22:55, Tom Lane wrote:
> Daniel Gustafsson <daniel@yesql.se> writes:
>>> On 10 Feb 2019, at 04:50, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Does anyone else feel that this is interesting/useful data?
>
>> Absolutely, +1 on this. In Greenplum we print the runtime of the script and
>> the runtime of the diff, both of which have provided useful feedback on where
>> to best spend optimization efforts (the diff time of course being a lot less
>> interesting in upstream postgres due to gpdb having it’s own diff tool to
>> handle segment variability).
>
> Seems like I'm far from the first to think of this --- I wonder why
> nobody submitted a patch before?
Now that I see this in action, it makes the actual test results harder
to identify flying by. I understand the desire to collect this timing
data, but that is a special use case and not relevant to the normal use
of the test suite, which is to see whether the test passes. Can we make
this optional please?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, daniel@yesql.se, pgsql-hackers@lists.postgresql.org
Subject: Re: Reporting script runtimes in pg_regress
In-Reply-To: <6f1657f9-c58c-ba28-0013-d36a6f6fd246@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox