pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feeddoc: minor update for description of "pg_roles" view
3+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2019-07-10 909a7b6b8e ff597b656f docs: remove pg_roles mention of the oid column being displayed
* doc: minor update for description of "pg_roles" view
@ 2019-07-10 05:35 Ian Barwick <ian.barwick@2ndquadrant.com>
0 siblings, 1 reply; 3+ messages in thread
From: Ian Barwick @ 2019-07-10 05:35 UTC (permalink / raw)
To: pgsql-hackers
Hi
Here:
https://www.postgresql.org/docs/12/view-pg-roles.html
we state:
"This view explicitly exposes the OID column of the underlying table,
since that is needed to do joins to other catalogs."
I think it's superfluous to mention this now OIDs are exposed by default;
attached patch (for REL_12_STABLE and HEAD) simply removes this sentence.
Regards
Ian Barwick
--
Ian Barwick https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachments:
view-pg_roles.v1.patch (text/x-patch, 565B) download
diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
new file mode 100644
index 3428a7c..68ad507
*** a/doc/src/sgml/catalogs.sgml
--- b/doc/src/sgml/catalogs.sgml
*************** SELECT * FROM pg_locks pl LEFT JOIN pg_p
*** 9995,10005 ****
that blanks out the password field.
</para>
- <para>
- This view explicitly exposes the OID column of the underlying table,
- since that is needed to do joins to other catalogs.
- </para>
-
<table>
<title><structname>pg_roles</structname> Columns</title>
--- 9995,10000 ----
* Re: doc: minor update for description of "pg_roles" view
@ 2019-07-10 18:24 Bruce Momjian <bruce@momjian.us>
parent: Ian Barwick <ian.barwick@2ndquadrant.com>
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Momjian @ 2019-07-10 18:24 UTC (permalink / raw)
To: Ian Barwick <ian.barwick@2ndquadrant.com>; +Cc: pgsql-hackers
On Wed, Jul 10, 2019 at 02:35:56PM +0900, Ian Barwick wrote:
> Hi
>
> Here:
>
> https://www.postgresql.org/docs/12/view-pg-roles.html
>
> we state:
>
> "This view explicitly exposes the OID column of the underlying table,
> since that is needed to do joins to other catalogs."
>
> I think it's superfluous to mention this now OIDs are exposed by default;
> attached patch (for REL_12_STABLE and HEAD) simply removes this sentence.
Patch applied though PG 12. Thanks.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: doc: minor update for description of "pg_roles" view
@ 2019-07-11 00:05 Ian Barwick <ian.barwick@2ndquadrant.com>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 3+ messages in thread
From: Ian Barwick @ 2019-07-11 00:05 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: pgsql-hackers
On 7/11/19 3:24 AM, Bruce Momjian wrote:
> On Wed, Jul 10, 2019 at 02:35:56PM +0900, Ian Barwick wrote:
>> Hi
>>
>> Here:
>>
>> https://www.postgresql.org/docs/12/view-pg-roles.html
>>
>> we state:
>>
>> "This view explicitly exposes the OID column of the underlying table,
>> since that is needed to do joins to other catalogs."
>>
>> I think it's superfluous to mention this now OIDs are exposed by default;
>> attached patch (for REL_12_STABLE and HEAD) simply removes this sentence.
>
> Patch applied though PG 12. Thanks.
Thanks!
Regards
Ian Barwick
--
Ian Barwick https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2019-07-11 00:05 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-07-10 05:35 doc: minor update for description of "pg_roles" view Ian Barwick <ian.barwick@2ndquadrant.com>
2019-07-10 18:24 ` Bruce Momjian <bruce@momjian.us>
2019-07-11 00:05 ` Ian Barwick <ian.barwick@2ndquadrant.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox