From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Khandekar <amitdkhan.pg@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Alvaro Herrera from 2ndQuadrant <alvherre@alvh.no-ip.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: logical decoding : exceeded maxAllocatedDescs for .spill files
Date: Fri, 13 Sep 2019 12:14:32 -0400
Message-ID: <7005.1568391272@sss.pgh.pa.us> (raw)
In-Reply-To: <CAJ3gD9fmQ8Vd_YbvTt2u_HsBmpKBN9OvZP0hSXhVrS4n21aQQQ@mail.gmail.com>
References: <CAJ3gD9c-sECEn79zXw4yBnBdOttacoE-6gAyP0oy60nfs_sabQ@mail.gmail.com>
<20190911125140.GA21034@alvherre.pgsql>
<20190912093055.exeatfemzr3f25yx@development>
<CA+TgmobZM1-0c2WZ0xy9hrwh-m18xem0+xGmAt9BA2o7zb9jDg@mail.gmail.com>
<CAJ3gD9fmQ8Vd_YbvTt2u_HsBmpKBN9OvZP0hSXhVrS4n21aQQQ@mail.gmail.com>
Amit Khandekar <amitdkhan.pg@gmail.com> writes:
> You mean tracking excess kernel fds right ? Yeah, we can use VFDs so
> that excess fds are automatically closed. But Alvaro seems to be
> talking in context of tracking of file seek position. VFD does not
> have a mechanism to track file offsets if one of the vfd cached file
> is closed and reopened.
Hm. It used to, but somebody got rid of that on the theory that
we could use pread/pwrite instead. I'm inclined to think that that
was the right tradeoff, but it'd mean that getting logical decoding
to adhere to the VFD API requires extra work to track file position
on the caller side.
Again, though, the advice that's been given here is that we should
fix logical decoding to use the VFD API as it stands, not change
that API. I concur with that.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, amitdkhan.pg@gmail.com, robertmhaas@gmail.com, tomas.vondra@2ndquadrant.com, alvherre@alvh.no-ip.org, pgsql-hackers@lists.postgresql.org
Subject: Re: logical decoding : exceeded maxAllocatedDescs for .spill files
In-Reply-To: <7005.1568391272@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox