From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Andy Fan <zhihuifan1213@163.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgbench error: (setshell) of script 0; execution of meta-command failed
Date: Tue, 14 Jan 2025 14:52:29 -0500
Message-ID: <717458.1736884349@sss.pgh.pa.us> (raw)
In-Reply-To: <Z4aRAdGdw8GiU7ba@nathan>
References: <87msfz5qv2.fsf@163.com>
<87ikqn5em7.fsf@163.com>
<e03fc711-8c48-4fb8-ba94-0862c920c30f@oss.nttdata.com>
<b0afe844-84b7-4154-ad2c-6763ff84d876@oss.nttdata.com>
<2422778.1736521065@sss.pgh.pa.us>
<2425050.1736522451@sss.pgh.pa.us>
<127979.1736622253@sss.pgh.pa.us>
<Z4U5j_FWpNLjtdU8@nathan>
<570943.1736808714@sss.pgh.pa.us>
<Z4aRAdGdw8GiU7ba@nathan>
Nathan Bossart <nathandbossart@gmail.com> writes:
> On Mon, Jan 13, 2025 at 05:51:54PM -0500, Tom Lane wrote:
>> (plus or minus an extern or so, but you get the idea). The point of
>> this is that compiling against old headers and then linking against
>> newer libpgport.a would still work. It does nothing however for the
>> reverse scenario of compiling against new headers and then linking
>> against old libpgport.a. So I haven't persuaded myself that it's
>> worth the trouble -- but I'm happy to include it if others think
>> it would help.
> After sleeping on it, I think I agree that the extra gymnastics aren't
> worth it to partially fix something that wasn't supported anyway. But I'm
> not mortally opposed to it if someone feels strongly that it should be
> included.
After more thought I've realized that the asymmetrical detection
here isn't all that bad, because the outcomes are different.
If we fail to catch old-headers-and-new-library, the result will
either be a link failure or (if the extension uses libpq) silently
linking to libpq's pqsignal, which was likely not what was intended.
If we fail to catch the other case, the result is always a link
failure, and that will happen at build time not in the field.
So now I'm inclined to include the ABI-compatible wrapper, which
will ensure that extensions continue to link to libpgport's pqsignal.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, nathandbossart@gmail.com, masao.fujii@oss.nttdata.com, zhihuifan1213@163.com, pgsql-hackers@lists.postgresql.org
Subject: Re: pgbench error: (setshell) of script 0; execution of meta-command failed
In-Reply-To: <717458.1736884349@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox